Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2665503002: Make |ScriptLoader::m_characterEncoding| a local variable (Closed)

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make |ScriptLoader::m_characterEncoding| a local variable In the spec, |encoding| is a local variable of "prepare a script". This doesn't change behavior. This CL also removes |ScriptLoader::m_fallbackCharacterEncoding| that is not used at all. Spec: https://html.spec.whatwg.org/#prepare-a-script BUG=686281 Review-Url: https://codereview.chromium.org/2665503002 Cr-Commit-Position: refs/heads/master@{#446908} Committed: https://chromium.googlesource.com/chromium/src/+/7a12f25e6aac98ef911351297135cc7f02996621

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 3 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 4 chunks +6 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
hiroshige
3 years, 10 months ago (2017-01-27 23:02:56 UTC) #5
kouhei (in TOK)
lgtm
3 years, 10 months ago (2017-01-28 04:35:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665503002/1
3 years, 10 months ago (2017-01-28 04:35:15 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 04:42:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7a12f25e6aac98ef911351297135...

Powered by Google App Engine
This is Rietveld 408576698