Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2658213004: [TEST] Forbid reentering ScriptLoader::prepareScript()

Created:
3 years, 10 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TEST] Forbid reentering ScriptLoader::prepareScript() BUG=

Patch Set 1 #

Patch Set 2 : more DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptLoader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptLoader.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (6 generated)
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-28 00:46:58 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658213004/1
3 years, 10 months ago (2017-01-28 00:47:22 UTC) #2
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-28 01:38:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2658213004/20001
3 years, 10 months ago (2017-01-28 01:38:53 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-28 03:25:56 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 03:25:56 UTC) #6
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698