Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2665433002: [Merge M57] Use uniform margin for icon, label and sublabel (Closed)

Created:
3 years, 10 months ago by csashi
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, jam, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, dcheng, mathp+autofillwatch_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M57] Uses uniform margin for icon, label and sublabel in order to make all of the green distances here equal to the orange distance in the picture below: https://drive.google.com/file/d/0B1qGSlvsjCymNVE1eGJVWW40TWM/view?usp=sharing New layout for credit card after this change: https://drive.google.com/file/d/0B1qGSlvsjCymMGxWUkI5aThVNFU/view?usp=sharing New layout for user name and address that uses same margin as for expanded credit card popup layout. https://screenshot.googleplex.com/HoJLy2bT2BO.png NOTRY=true NOPRESUBMIT=true TBR=sgurun@chromium.org BUG=686287 Review-Url: https://codereview.chromium.org/2665433002 Cr-Commit-Position: refs/branch-heads/2987@{#174} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/c26ca96a8e1b6ffdcc68b67ea09e0d0cff0b7134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -34 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_layout_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_layout_model.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/android/java/src/org/chromium/components/autofill/AutofillPopup.java View 2 chunks +5 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.h View 1 chunk +5 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_experiments.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/SelectPopupDropdown.java View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/res/layout/dropdown_item.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/DropdownAdapter.java View 7 chunks +45 lines, -22 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
csashi
On 2017/01/27 20:25:23, csashi wrote: > mailto:csashi@google.com changed reviewers: > + mailto:mathp@chromium.org, mailto:sgurun@chromium.org, mailto:tedchoc@chromium.org Hi, ...
3 years, 10 months ago (2017-01-27 20:26:08 UTC) #3
Ted C
On 2017/01/27 20:26:08, csashi wrote: > On 2017/01/27 20:25:23, csashi wrote: > > mailto:csashi@google.com changed ...
3 years, 10 months ago (2017-01-27 20:43:43 UTC) #4
sgurun-gerrit only
On 2017/01/27 20:43:43, Ted C wrote: > On 2017/01/27 20:26:08, csashi wrote: > > On ...
3 years, 10 months ago (2017-01-27 21:12:10 UTC) #5
Mathieu
On 2017/01/27 21:12:10, sgurun wrote: > On 2017/01/27 20:43:43, Ted C wrote: > > On ...
3 years, 10 months ago (2017-01-27 21:57:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665433002/1
3 years, 10 months ago (2017-01-28 00:06:08 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-01-28 00:06:09 UTC) #11
csashi
On 2017/01/27 20:43:43, Ted C wrote: > On 2017/01/27 20:26:08, csashi wrote: > > On ...
3 years, 10 months ago (2017-01-28 00:16:59 UTC) #13
Ted C
On 2017/01/28 00:16:59, csashi wrote: > On 2017/01/27 20:43:43, Ted C wrote: > > On ...
3 years, 10 months ago (2017-01-28 00:20:52 UTC) #14
Mathieu
autofill lgtm, I see the merge was approved
3 years, 10 months ago (2017-01-30 19:28:55 UTC) #15
Ted C
lgtm
3 years, 10 months ago (2017-01-30 19:46:23 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665433002/1
3 years, 10 months ago (2017-01-30 19:47:40 UTC) #19
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-01-30 19:47:45 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2665433002/1
3 years, 10 months ago (2017-01-30 19:49:07 UTC) #24
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 19:51:12 UTC) #27
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c26ca96a8e1b6ffdcc68b67ea09e...

Powered by Google App Engine
This is Rietveld 408576698