Description was changed from ========== Merges 2649623002 to M57. BUG= ========== to ========== Merges 2649623002 ...
3 years, 10 months ago
(2017-01-27 20:25:23 UTC)
#1
Description was changed from
==========
Merges 2649623002 to M57.
BUG=
==========
to
==========
Merges 2649623002 to M57.
https://codereview.chromium.org/2649623002/
BUG=
==========
3 years, 10 months ago
(2017-01-27 20:26:08 UTC)
#3
On 2017/01/27 20:25:23, csashi wrote:
> mailto:csashi@google.com changed reviewers:
> + mailto:mathp@chromium.org, mailto:sgurun@chromium.org,
mailto:tedchoc@chromium.org
Hi,
Can you please approve this merge of https://codereview.chromium.org/2649623002/
that you just reviewed to 57 branch?
Thanks,
-sashi.
Ted C
On 2017/01/27 20:26:08, csashi wrote: > On 2017/01/27 20:25:23, csashi wrote: > > mailto:csashi@google.com changed ...
3 years, 10 months ago
(2017-01-27 20:43:43 UTC)
#4
On 2017/01/27 20:26:08, csashi wrote:
> On 2017/01/27 20:25:23, csashi wrote:
> > mailto:csashi@google.com changed reviewers:
> > + mailto:mathp@chromium.org, mailto:sgurun@chromium.org,
> mailto:tedchoc@chromium.org
>
> Hi,
> Can you please approve this merge of
https://codereview.chromium.org/2649623002/
> that you just reviewed to 57 branch?
> Thanks,
> -sashi.
Before you merge to 57, you need to link this change to a bug that has merge
approval on it.
sgurun-gerrit only
On 2017/01/27 20:43:43, Ted C wrote: > On 2017/01/27 20:26:08, csashi wrote: > > On ...
3 years, 10 months ago
(2017-01-27 21:12:10 UTC)
#5
On 2017/01/27 20:43:43, Ted C wrote:
> On 2017/01/27 20:26:08, csashi wrote:
> > On 2017/01/27 20:25:23, csashi wrote:
> > > mailto:csashi@google.com changed reviewers:
> > > + mailto:mathp@chromium.org, mailto:sgurun@chromium.org,
> > mailto:tedchoc@chromium.org
> >
> > Hi,
> > Can you please approve this merge of
> https://codereview.chromium.org/2649623002/
> > that you just reviewed to 57 branch?
> > Thanks,
> > -sashi.
>
> Before you merge to 57, you need to link this change to a bug that has merge
> approval on it.
and once you have merge approval, you can tbr us, I think.
Mathieu
On 2017/01/27 21:12:10, sgurun wrote: > On 2017/01/27 20:43:43, Ted C wrote: > > On ...
3 years, 10 months ago
(2017-01-27 21:57:55 UTC)
#6
On 2017/01/27 21:12:10, sgurun wrote:
> On 2017/01/27 20:43:43, Ted C wrote:
> > On 2017/01/27 20:26:08, csashi wrote:
> > > On 2017/01/27 20:25:23, csashi wrote:
> > > > mailto:csashi@google.com changed reviewers:
> > > > + mailto:mathp@chromium.org, mailto:sgurun@chromium.org,
> > > mailto:tedchoc@chromium.org
> > >
> > > Hi,
> > > Can you please approve this merge of
> > https://codereview.chromium.org/2649623002/
> > > that you just reviewed to 57 branch?
> > > Thanks,
> > > -sashi.
> >
> > Before you merge to 57, you need to link this change to a bug that has merge
> > approval on it.
>
> and once you have merge approval, you can tbr us, I think.
Also the description of the change should be
[Merge M57] <full original change description>
(i.e. just prepend [Merge M57] to the whole previous change description)
csashi
Description was changed from ========== Merges 2649623002 to M57. https://codereview.chromium.org/2649623002/ BUG= ========== to ========== [Merge ...
3 years, 10 months ago
(2017-01-27 22:54:10 UTC)
#7
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago
(2017-01-28 00:06:09 UTC)
#11
No L-G-T-M from a valid reviewer yet.
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
csashi
Description was changed from ========== [Merge M57] Uses uniform margin for icon, label and sublabel ...
3 years, 10 months ago
(2017-01-28 00:14:42 UTC)
#12
On 2017/01/27 20:43:43, Ted C wrote: > On 2017/01/27 20:26:08, csashi wrote: > > On ...
3 years, 10 months ago
(2017-01-28 00:16:59 UTC)
#13
On 2017/01/27 20:43:43, Ted C wrote:
> On 2017/01/27 20:26:08, csashi wrote:
> > On 2017/01/27 20:25:23, csashi wrote:
> > > mailto:csashi@google.com changed reviewers:
> > > + mailto:mathp@chromium.org, mailto:sgurun@chromium.org,
> > mailto:tedchoc@chromium.org
> >
> > Hi,
> > Can you please approve this merge of
> https://codereview.chromium.org/2649623002/
> > that you just reviewed to 57 branch?
> > Thanks,
> > -sashi.
>
> Before you merge to 57, you need to link this change to a bug that has merge
> approval on it.
Hi,
I have linked the bug. Can you let me know if there are additional steps?
Thanks,
-sashi.
Ted C
On 2017/01/28 00:16:59, csashi wrote: > On 2017/01/27 20:43:43, Ted C wrote: > > On ...
3 years, 10 months ago
(2017-01-28 00:20:52 UTC)
#14
On 2017/01/28 00:16:59, csashi wrote:
> On 2017/01/27 20:43:43, Ted C wrote:
> > On 2017/01/27 20:26:08, csashi wrote:
> > > On 2017/01/27 20:25:23, csashi wrote:
> > > > mailto:csashi@google.com changed reviewers:
> > > > + mailto:mathp@chromium.org, mailto:sgurun@chromium.org,
> > > mailto:tedchoc@chromium.org
> > >
> > > Hi,
> > > Can you please approve this merge of
> > https://codereview.chromium.org/2649623002/
> > > that you just reviewed to 57 branch?
> > > Thanks,
> > > -sashi.
> >
> > Before you merge to 57, you need to link this change to a bug that has merge
> > approval on it.
>
> Hi,
> I have linked the bug. Can you let me know if there are additional steps?
> Thanks,
> -sashi.
There will be an update on the bug when it is merge approved or rejected,
just ping us then and we can help.
Mathieu
autofill lgtm, I see the merge was approved
3 years, 10 months ago
(2017-01-30 19:28:55 UTC)
#15
autofill lgtm, I see the merge was approved
Ted C
lgtm
3 years, 10 months ago
(2017-01-30 19:46:23 UTC)
#16
lgtm
Ted C
Description was changed from ========== [Merge M57] Uses uniform margin for icon, label and sublabel ...
3 years, 10 months ago
(2017-01-30 19:46:54 UTC)
#17
Issue 2665433002: [Merge M57] Use uniform margin for icon, label and sublabel
(Closed)
Created 3 years, 10 months ago by csashi
Modified 3 years, 10 months ago
Reviewers: Mathieu, Ted C, sgurun-gerrit only
Base URL:
Comments: 0