chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java - Issue 2665433002: [Merge M57] Use uniform margin for icon, label and sublabel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

Issue 2665433002: [Merge M57] Use uniform margin for icon, label and sublabel (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwAutofillClient.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

index b5adb64387e022e6d4b4b8f0eeb9b12a27897614..20a422c71d2963a14300ec6a59b6f933bd124b90 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupBridge.java

@@ -99,12 +99,14 @@ public class AutofillPopupBridge implements AutofillDelegate, DialogInterface.On

* not specified in experiment.

* @param dropdownItemHeight height of each dropdown item in dimension independent pixel units,

* 0 if not specified in experiment.

+ * @param margin Margin for icon, label and between icon and label in dimension independent

+ * pixel units, 0 if not specified in experiment.

@CalledByNative

private void show(AutofillSuggestion[] suggestions, boolean isRtl, int backgroundColor,

- int dividerColor, int dropdownItemHeight) {

+ int dividerColor, int dropdownItemHeight, int margin) {

if (mAutofillPopup != null) mAutofillPopup.filterAndShow(suggestions, isRtl,

- backgroundColor, dividerColor, dropdownItemHeight);

+ backgroundColor, dividerColor, dropdownItemHeight, margin);

}

@CalledByNative