Update web shell app to not load dev.chromium.org on launch.

Update web shell app to not load dev.chromium.org on launch.

Loading this can delay tests that typically use the fake HTTP
server. This includes a few synchronization fixes when loading
URLs.

BUG=685412
Review-Url: https://codereview.chromium.org/2665423002
Cr-Commit-Position: refs/heads/master@{#447611}
Committed: https://chromium.googlesource.com/chromium/src/+/3432563dba5d8feb7819262688a0741a66c6bf35

[baxley, 2017-02-01 20:44:21]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-02-01 20:47:54]

ios/web lgtm

https://codereview.chromium.org/2665423002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.mm
(left):

https://codereview.chromium.org/2665423002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.mm:49:
web::NavigationManager::WebLoadParams params(
This is not a part of web_shell, so if you want to make this change you should
probably ask marq@ for review.

[baxley, 2017-02-01 20:55:02]

https://codereview.chromium.org/2665423002/diff/1/ios/clean/chrome/browser/ui...
File ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.mm
(left):

https://codereview.chromium.org/2665423002/diff/1/ios/clean/chrome/browser/ui...
ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.mm:49:
web::NavigationManager::WebLoadParams params(
On 2017/02/01 20:47:54, Eugene But wrote:
> This is not a part of web_shell, so if you want to make this change you should
> probably ask marq@ for review.

Sorry, I thought I removed this from the CL. I has now been removed, and that
should be handled separately. Nice catch!

[baxley, 2017-02-01 20:55:15]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-02-01 20:55:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2665423002/#ps20001
(title: "remove chrome code")

[commit-bot: I haz the power, 2017-02-01 20:55:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 21:20:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485982515855340,
"parent_rev": "8db816e5533f4447c4c4fabc6ad9be956f354c71", "commit_rev":
"3432563dba5d8feb7819262688a0741a66c6bf35"}

[commit-bot: I haz the power, 2017-02-01 21:21:38]

Description was changed from

==========
Update web shell app to not load dev.chromium.org on launch.

Loading this can delay tests that typically use the fake HTTP
server. This includes a few synchronization fixes when loading
URLs.

BUG=685412
==========

to

==========
Update web shell app to not load dev.chromium.org on launch.

Loading this can delay tests that typically use the fake HTTP
server. This includes a few synchronization fixes when loading
URLs.

BUG=685412

Review-Url: https://codereview.chromium.org/2665423002
Cr-Commit-Position: refs/heads/master@{#447611}
Committed:
https://chromium.googlesource.com/chromium/src/+/3432563dba5d8feb7819262688a0...
==========

[commit-bot: I haz the power, 2017-02-01 21:21:39]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3432563dba5d8feb7819262688a0...