Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.mm

Issue 2665423002: Update web shell app to not load dev.chromium.org on launch. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ios/web/shell/test/earl_grey/shell_base_test_case.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // ====== New Architecture ===== 5 // ====== New Architecture =====
6 // = This code is only used in the new iOS Chrome architecture. = 6 // = This code is only used in the new iOS Chrome architecture. =
7 // ============================================================================ 7 // ============================================================================
8 8
9 #import "ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.h " 9 #import "ios/clean/chrome/browser/ui/web_contents/web_contents_view_controller.h "
10 10
(...skipping 26 matching lines...) Expand all
37 [self.view addSubview:webContentsView]; 37 [self.view addSubview:webContentsView];
38 [NSLayoutConstraint activateConstraints:@[ 38 [NSLayoutConstraint activateConstraints:@[
39 [webContentsView.topAnchor constraintEqualToAnchor:self.view.topAnchor], 39 [webContentsView.topAnchor constraintEqualToAnchor:self.view.topAnchor],
40 [webContentsView.bottomAnchor 40 [webContentsView.bottomAnchor
41 constraintEqualToAnchor:self.view.bottomAnchor], 41 constraintEqualToAnchor:self.view.bottomAnchor],
42 [webContentsView.leadingAnchor 42 [webContentsView.leadingAnchor
43 constraintEqualToAnchor:self.view.leadingAnchor], 43 constraintEqualToAnchor:self.view.leadingAnchor],
44 [webContentsView.trailingAnchor 44 [webContentsView.trailingAnchor
45 constraintEqualToAnchor:self.view.trailingAnchor], 45 constraintEqualToAnchor:self.view.trailingAnchor],
46 ]]; 46 ]];
47
48 if (!self.webState->GetNavigationManager()->GetItemCount()) {
49 web::NavigationManager::WebLoadParams params(
Eugene But (OOO till 7-30) 2017/02/01 20:47:54 This is not a part of web_shell, so if you want to
baxley 2017/02/01 20:55:02 Sorry, I thought I removed this from the CL. I has
50 GURL("https://dev.chromium.org/"));
51 params.transition_type = ui::PAGE_TRANSITION_TYPED;
52 _webState->GetNavigationManager()->LoadURLWithParams(params);
53 }
54 } 47 }
55 48
56 @end 49 @end
OLDNEW
« no previous file with comments | « no previous file | ios/web/shell/test/earl_grey/shell_base_test_case.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698