Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 266533003: Reland "Trigger exception debug event for promises at the throw site." (Closed)

Created:
6 years, 7 months ago by Yang
Modified:
6 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Reland "Trigger exception debug event for promises at the throw site." R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21097

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -115 lines) Patch
M include/v8-debug.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/debug.h View 1 3 chunks +15 lines, -3 lines 0 comments Download
M src/debug.cc View 1 7 chunks +56 lines, -9 lines 1 comment Download
M src/debug-debugger.js View 1 chunk +1 line, -2 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/mirror-debugger.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/promise.js View 1 4 chunks +13 lines, -20 lines 0 comments Download
M src/runtime.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +15 lines, -6 lines 0 comments Download
M test/mjsunit/es6/debug-promises-caught-all.js View 2 chunks +2 lines, -3 lines 0 comments Download
A + test/mjsunit/es6/debug-promises-caught-late.js View 2 chunks +6 lines, -10 lines 0 comments Download
M test/mjsunit/es6/debug-promises-caught-uncaught.js View 2 chunks +1 line, -3 lines 0 comments Download
A test/mjsunit/es6/debug-promises-reentry.js View 1 1 chunk +17 lines, -0 lines 0 comments Download
A + test/mjsunit/es6/debug-promises-throw-in-constructor.js View 2 chunks +12 lines, -20 lines 0 comments Download
M test/mjsunit/es6/debug-promises-throw-in-reject.js View 3 chunks +6 lines, -6 lines 0 comments Download
M test/mjsunit/es6/debug-promises-uncaught-all.js View 2 chunks +8 lines, -15 lines 0 comments Download
M test/mjsunit/es6/debug-promises-uncaught-uncaught.js View 3 chunks +5 lines, -5 lines 0 comments Download
M test/mjsunit/es6/debug-promises-undefined-reject.js View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Second patch set is the fix. I was naive. It turns out that we could ...
6 years, 7 months ago (2014-04-30 15:12:18 UTC) #1
Yang
https://codereview.chromium.org/266533003/diff/20001/src/debug.cc File src/debug.cc (right): https://codereview.chromium.org/266533003/diff/20001/src/debug.cc#newcode1334 src/debug.cc:1334: if (promise_catch_handlers_.length() == 0) return; This is to make ...
6 years, 7 months ago (2014-04-30 15:13:32 UTC) #2
rossberg
lgtm
6 years, 7 months ago (2014-04-30 15:16:34 UTC) #3
Yang
6 years, 7 months ago (2014-04-30 15:18:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21097 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698