Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: test/mjsunit/es6/debug-promises-uncaught-all.js

Issue 266533003: Reland "Trigger exception debug event for promises at the throw site." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es6/debug-promises-uncaught-all.js
diff --git a/test/mjsunit/es6/debug-promises-uncaught-all.js b/test/mjsunit/es6/debug-promises-uncaught-all.js
index 7ee8cb2b68066baa0dd93ca3fce848e05982e66f..714e7da9c58e8c4ef407dcf980fc90edcdbc7d22 100644
--- a/test/mjsunit/es6/debug-promises-uncaught-all.js
+++ b/test/mjsunit/es6/debug-promises-uncaught-all.js
@@ -6,10 +6,7 @@
// Test debug events when we listen to all exceptions and
// there is a catch handler for the exception thrown in a Promise.
-// Expectation:
-// - the normal Exception debug event is triggered.
-// - the PendingExceptionInPromise debug event is triggered afterwards,
-// with the same exception object.
+// We expect an Exception debug event with a promise to be triggered.
Debug = debug.Debug;
@@ -25,28 +22,24 @@ var p = new Promise(function(resolve, reject) {
var q = p.chain(
function() {
log.push("throw");
- throw new Error("uncaught");
+ throw new Error("uncaught"); // event
});
function listener(event, exec_state, event_data, data) {
try {
// Ignore exceptions during startup in stress runs.
- if (step > 1) return;
+ if (step >= 1) return;
assertEquals(["resolve", "end main", "throw"], log);
if (event == Debug.DebugEvent.Exception) {
assertEquals(0, step);
- exception = event_data.exception();
- assertEquals(undefined, event_data.promise());
- } else if (event == Debug.DebugEvent.PendingExceptionInPromise) {
- assertEquals(1, step);
- assertEquals(exception, event_data.exception());
- assertEquals("uncaught", exception.message);
+ assertEquals("uncaught", event_data.exception().message);
assertTrue(event_data.promise() instanceof Promise);
+ assertEquals(q, event_data.promise());
assertTrue(event_data.uncaught());
- } else {
- return;
+ // Assert that the debug event is triggered at the throw site.
+ assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0);
+ step++;
}
- step++;
} catch (e) {
// Signal a failure with exit code 1. This is necessary since the
// debugger swallows exceptions and we expect the chained function

Powered by Google App Engine
This is Rietveld 408576698