[csa] Universally use ParameterMode in BuildFastFixedArrayForEach

[csa] Universally use ParameterMode in BuildFastFixedArrayForEach

This allows support for tagged representations of index/loop variables which
asserted in BuildFastFixedArrayForEach's call to Increment up to this point.

Review-Url: https://codereview.chromium.org/2665143002
Cr-Commit-Position: refs/heads/master@{#42863}
Committed: https://chromium.googlesource.com/v8/v8/+/c9f7f303b9f59a674bdfe39365996e61dcbf553f

[danno, 2017-01-31 13:40:08]

The CQ bit was checked by danno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 13:40:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2017-01-31 13:42:16]

Description was changed from

==========
[csa] Universally use ParameterMode in BuildFastFixedArrayForEach

This allows support for Tagged representations of index/loop variables which
asserted in BuildFastFixedArrayForEach's call to Increment up to this point.
==========

to

==========
[csa] Universally use ParameterMode in BuildFastFixedArrayForEach

This allows support for tagged representations of index/loop variables which
asserted in BuildFastFixedArrayForEach's call to Increment up to this point.
==========

[commit-bot: I haz the power, 2017-01-31 14:05:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 14:05:20]

Dry run: This issue passed the CQ dry run.

[danno, 2017-01-31 14:12:28]

danno@chromium.org changed reviewers:
+ ishell@chromium.org

[danno, 2017-01-31 14:12:29]

PTAL

[Igor Sheludko, 2017-02-01 17:12:53]

lgtm once you address the comments.

Please run the tests on ia32 with enabled graph verifier.

https://codereview.chromium.org/2665143002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2665143002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:2356: from_increment, INTPTR_PARAMETERS,
IndexAdvanceMode::kPost);
mode

https://codereview.chromium.org/2665143002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:6344: INTPTR_PARAMETERS,
mode

[danno, 2017-02-01 17:33:43]

Feedback addressed, landing.

https://codereview.chromium.org/2665143002/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2665143002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:2356: from_increment, INTPTR_PARAMETERS,
IndexAdvanceMode::kPost);
On 2017/02/01 17:12:53, Igor Sheludko wrote:
> mode

As discussed, this is correct as-is.

https://codereview.chromium.org/2665143002/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:6344: INTPTR_PARAMETERS,
On 2017/02/01 17:12:53, Igor Sheludko wrote:
> mode

As discussed, this is correct as-is.

[danno, 2017-02-01 17:34:04]

The CQ bit was checked by danno@chromium.org

[commit-bot: I haz the power, 2017-02-01 17:34:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 18:23:15]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485970444246820, "parent_rev":
"d8ab932ceb3b906f36ab3216f84d8e626b3e5a5e", "commit_rev":
"c9f7f303b9f59a674bdfe39365996e61dcbf553f"}

[commit-bot: I haz the power, 2017-02-01 18:23:22]

Description was changed from

==========
[csa] Universally use ParameterMode in BuildFastFixedArrayForEach

This allows support for tagged representations of index/loop variables which
asserted in BuildFastFixedArrayForEach's call to Increment up to this point.
==========

to

==========
[csa] Universally use ParameterMode in BuildFastFixedArrayForEach

This allows support for tagged representations of index/loop variables which
asserted in BuildFastFixedArrayForEach's call to Increment up to this point.

Review-Url: https://codereview.chromium.org/2665143002
Cr-Commit-Position: refs/heads/master@{#42863}
Committed:
https://chromium.googlesource.com/v8/v8/+/c9f7f303b9f59a674bdfe39365996e61dcb...
==========

[commit-bot: I haz the power, 2017-02-01 18:23:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c9f7f303b9f59a674bdfe39365996e61dcb...