Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: src/code-stub-assembler.h

Issue 2665143002: [csa] Universally use ParameterMode in BuildFastFixedArrayForEach (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/code-stub-assembler.h
diff --git a/src/code-stub-assembler.h b/src/code-stub-assembler.h
index 8f08408e40ee8db9b14f57a08e9aa4da1e4e7f1b..214d534cb2d92e56e3ef12bf9c149d9c41635ac9 100644
--- a/src/code-stub-assembler.h
+++ b/src/code-stub-assembler.h
@@ -1075,16 +1075,17 @@ class V8_EXPORT_PRIVATE CodeStubAssembler : public compiler::CodeAssembler {
typedef std::function<void(Node* index)> FastLoopBody;
- Node* BuildFastLoop(const VariableList& var_list,
- MachineRepresentation index_rep, Node* start_index,
+ Node* BuildFastLoop(const VariableList& var_list, Node* start_index,
Node* end_index, const FastLoopBody& body, int increment,
- IndexAdvanceMode mode = IndexAdvanceMode::kPre);
-
- Node* BuildFastLoop(MachineRepresentation index_rep, Node* start_index,
- Node* end_index, const FastLoopBody& body, int increment,
- IndexAdvanceMode mode = IndexAdvanceMode::kPre) {
- return BuildFastLoop(VariableList(0, zone()), index_rep, start_index,
- end_index, body, increment, mode);
+ ParameterMode parameter_mode,
+ IndexAdvanceMode advance_mode = IndexAdvanceMode::kPre);
+
+ Node* BuildFastLoop(Node* start_index, Node* end_index,
+ const FastLoopBody& body, int increment,
+ ParameterMode parameter_mode,
+ IndexAdvanceMode advance_mode = IndexAdvanceMode::kPre) {
+ return BuildFastLoop(VariableList(0, zone()), start_index, end_index, body,
+ increment, parameter_mode, advance_mode);
}
enum class ForEachDirection { kForward, kReverse };

Powered by Google App Engine
This is Rietveld 408576698