Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to ARC.

Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to ARC.

This CL also renames a method that used to start with new to remove this prefix. 

BUG=624363
Review-Url: https://codereview.chromium.org/2664993003
Cr-Commit-Position: refs/heads/master@{#447505}
Committed: https://chromium.googlesource.com/chromium/src/+/17c21fefe0e32acf1196c71882e10277baf406c8

[noyau (Ping after 24h), 2017-01-31 13:31:31]

Patchset #1 (id:1) has been deleted

[noyau (Ping after 24h), 2017-01-31 13:48:32]

Description was changed from

==========
Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to
ARC.

BUG=624363
==========

to

==========
Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to
ARC.

This CL also renames a method that used to start with new to remove this prefix.


BUG=624363
==========

[noyau (Ping after 24h), 2017-01-31 13:48:33]

noyau@chromium.org changed reviewers:
+ stkhapugin@chromium.org

[noyau (Ping after 24h), 2017-01-31 13:48:40]

The CQ bit was checked by noyau@chromium.org to run a CQ dry run

[noyau (Ping after 24h), 2017-01-31 13:48:53]

PTAL

[commit-bot: I haz the power, 2017-01-31 13:48:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[stkhapugin, 2017-01-31 14:17:54]

stkhapugin@chromium.org changed reviewers:
+ eugenebut@chromium.org

[stkhapugin, 2017-01-31 14:17:55]

lgtm

https://codereview.chromium.org/2664993003/diff/40001/ios/chrome/browser/nati...
File ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm
(right):

https://codereview.chromium.org/2664993003/diff/40001/ios/chrome/browser/nati...
ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm:56:
__unsafe_unretained Tab* _tab;  // weak
This can now become a __weak.

https://codereview.chromium.org/2664993003/diff/40001/ios/public/provider/chr...
File
ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.mm
(right):

https://codereview.chromium.org/2664993003/diff/40001/ios/public/provider/chr...
ios/public/provider/chrome/browser/native_app_launcher/fake_native_app_whitelist_manager.mm:26:
- (id<NativeAppMetadata>)nativeAppForURL:(const GURL&)url {
Thank you for doing this.

[noyau (Ping after 24h), 2017-01-31 14:57:45]

[ObjC ARC] Converts
ios/chrome/browser/native_app_launcher:native_app_launcher_internal to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

[noyau (Ping after 24h), 2017-01-31 14:57:46]

The CQ bit was checked by noyau@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 14:57:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[noyau (Ping after 24h), 2017-01-31 15:07:24]

Eugene, for DEPS. I had to add a dependency to an ios/web include, as the
dependency was in the code but not in DEPS. I've updated the relevant bug:
http://crbug.com/619984

[Eugene But (OOO till 7-30), 2017-01-31 17:07:34]

DEPS lgtm. Thank you for heads up.

[pkl (ping after 24h if needed), 2017-02-01 00:46:10]

pkl@chromium.org changed reviewers:
+ pkl@chromium.org

[pkl (ping after 24h if needed), 2017-02-01 00:46:11]

drive-by

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
File ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm
(right):

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm:31:
#if !defined(__has_feature) || !__has_feature(objc_arc)
Do you really need this twice?

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
File ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm
(right):

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm:16: #if
!defined(__has_feature) || !__has_feature(objc_arc)
twice?

https://codereview.chromium.org/2664993003/diff/80001/ios/public/provider/chr...
File
ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h
(right):

https://codereview.chromium.org/2664993003/diff/80001/ios/public/provider/chr...
ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h:26:
// Returns a new object with the metadata about the iOS native application that
s/a new/an/

[noyau (Ping after 24h), 2017-02-01 11:24:10]

Fixed.

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
File ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm
(right):

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
ios/chrome/browser/native_app_launcher/native_app_navigation_controller.mm:31:
#if !defined(__has_feature) || !__has_feature(objc_arc)
On 2017/02/01 00:46:11, pklpkl wrote:
> Do you really need this twice?

Yes, to really really make sure!

Fixed.

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
File ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm
(right):

https://codereview.chromium.org/2664993003/diff/80001/ios/chrome/browser/nati...
ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm:16: #if
!defined(__has_feature) || !__has_feature(objc_arc)
On 2017/02/01 00:46:11, pklpkl wrote:
> twice?

Done. And we'll fix the script.

https://codereview.chromium.org/2664993003/diff/80001/ios/public/provider/chr...
File
ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h
(right):

https://codereview.chromium.org/2664993003/diff/80001/ios/public/provider/chr...
ios/public/provider/chrome/browser/native_app_launcher/native_app_whitelist_manager.h:26:
// Returns a new object with the metadata about the iOS native application that
On 2017/02/01 00:46:11, pklpkl wrote:
> s/a new/an/

Done.

[noyau (Ping after 24h), 2017-02-01 12:54:41]

The CQ bit was checked by noyau@chromium.org

[noyau (Ping after 24h), 2017-02-01 12:54:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2664993003/#ps100001
(title: "feedback")

[commit-bot: I haz the power, 2017-02-01 12:54:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 13:58:52]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485953681876710,
"parent_rev": "f1cc1504e6c65e517d233ce77bbd238135f97e05", "commit_rev":
"17c21fefe0e32acf1196c71882e10277baf406c8"}

[commit-bot: I haz the power, 2017-02-01 13:59:24]

Description was changed from

==========
Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to
ARC.

This CL also renames a method that used to start with new to remove this prefix.


BUG=624363
==========

to

==========
Converts ios/chrome/browser/native_app_launcher:native_app_launcher_internal to
ARC.

This CL also renames a method that used to start with new to remove this prefix.


BUG=624363

Review-Url: https://codereview.chromium.org/2664993003
Cr-Commit-Position: refs/heads/master@{#447505}
Committed:
https://chromium.googlesource.com/chromium/src/+/17c21fefe0e32acf1196c71882e1...
==========

[commit-bot: I haz the power, 2017-02-01 13:59:25]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/17c21fefe0e32acf1196c71882e1...