Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2664983004: Allow ShortcutHelper to retrieve badge icon dimensions. (Closed)

Created:
3 years, 10 months ago by F
Modified:
3 years, 10 months ago
Reviewers:
gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow ShortcutHelper to retrieve badge icon dimensions. Allow ShortcutHelper to retrieve minimum badge icon size and ideal badge icon size. Ideal badge icon size comes from Android Developers https://developer.android.com/guide/practices/ui_guidelines/icon_design_status_bar.html#size11. BUG=649771 Review-Url: https://codereview.chromium.org/2664983004 Cr-Commit-Position: refs/heads/master@{#447603} Committed: https://chromium.googlesource.com/chromium/src/+/e33ba85e0048b6998e3c7fbb02a6cece1ceae07b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressing comments #

Total comments: 2

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -33 lines) Patch
M chrome/android/java/res/values/dimens.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 2 5 chunks +19 lines, -9 lines 0 comments Download
M chrome/browser/android/shortcut_helper.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 2 4 chunks +31 lines, -22 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
F
Hi Dan, PTAL. Thanks!
3 years, 10 months ago (2017-02-01 00:53:21 UTC) #6
gone
https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java (right): https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java#newcode518 chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:518: * @param context Application context. Doesn't have to be ...
3 years, 10 months ago (2017-02-01 18:38:49 UTC) #9
F
Thanks Dan, PTAL! https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java (right): https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java#newcode518 chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:518: * @param context Application context. On ...
3 years, 10 months ago (2017-02-01 19:11:36 UTC) #11
gone
https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java (right): https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java#newcode571 chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:571: public static int getMinimumBadgeIconSizeInPx(Context context) { Given that this ...
3 years, 10 months ago (2017-02-01 19:15:05 UTC) #13
F
Thanks Dan, PTAL! https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java (right): https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java#newcode571 chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:571: public static int getMinimumBadgeIconSizeInPx(Context context) { ...
3 years, 10 months ago (2017-02-01 19:27:19 UTC) #15
gone
lgtm
3 years, 10 months ago (2017-02-01 19:41:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664983004/40001
3 years, 10 months ago (2017-02-01 19:45:27 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 20:55:45 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e33ba85e0048b6998e3c7fbb02a6...

Powered by Google App Engine
This is Rietveld 408576698