Allow ShortcutHelper to retrieve badge icon dimensions.

Allow ShortcutHelper to retrieve badge icon dimensions.

Allow ShortcutHelper to retrieve minimum badge icon size and ideal
badge icon size. Ideal badge icon size comes from Android Developers
https://developer.android.com/guide/practices/ui_guidelines/icon_design_status_bar.html#size11.

BUG=649771
Review-Url: https://codereview.chromium.org/2664983004
Cr-Commit-Position: refs/heads/master@{#447603}
Committed: https://chromium.googlesource.com/chromium/src/+/e33ba85e0048b6998e3c7fbb02a6cece1ceae07b

[F, 2017-01-31 23:27:57]

Description was changed from

==========
Allow ShorcutHelper to retrieve badge icon dimensions.

BUG=
==========

to

==========
Allow ShortcutHelper to retrieve badge icon dimensions.

BUG=649771
==========

[F, 2017-01-31 23:28:04]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 23:28:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[F, 2017-01-31 23:33:24]

Description was changed from

==========
Allow ShortcutHelper to retrieve badge icon dimensions.

BUG=649771
==========

to

==========
Allow ShortcutHelper to retrieve badge icon dimensions.

Allow ShortcutHelper to retrieve minimum badge icon size and ideal
badge icon size. Ideal badge icon size comes from Android Developers
https://developer.android.com/guide/practices/ui_guidelines/icon_design_statu....

BUG=649771
==========

[F, 2017-02-01 00:53:21]

zpeng@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[F, 2017-02-01 00:53:21]

Hi Dan, PTAL. Thanks!

[commit-bot: I haz the power, 2017-02-01 00:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 00:56:24]

Dry run: This issue passed the CQ dry run.

[gone, 2017-02-01 18:38:49]

https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:518: *
@param context Application context.
Doesn't have to be an application context; I'd just say "Context to pull
resources from" or something.

https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:571:
public static int getMinimumBadgeIconSizeInPx(Context context) {
I don't think it makes sense to allow fudging this value.  The reason the fudge
was allowed for splash screens was that people were using relatively large
images that could be stretched up without looking too terrible.  Given that
badges are relatively small already, trying to stretch them up could look really
bad.

[F, 2017-02-01 19:11:24]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[F, 2017-02-01 19:11:36]

Thanks Dan, PTAL!

https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:518: *
@param context Application context.
On 2017/02/01 18:38:49, dfalcantara (load balance plz) wrote:
> Doesn't have to be an application context; I'd just say "Context to pull
> resources from" or something.

Done.

https://codereview.chromium.org/2664983004/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:571:
public static int getMinimumBadgeIconSizeInPx(Context context) {
On 2017/02/01 18:38:49, dfalcantara (load balance plz) wrote:
> I don't think it makes sense to allow fudging this value.  The reason the
fudge
> was allowed for splash screens was that people were using relatively large
> images that could be stretched up without looking too terrible.  Given that
> badges are relatively small already, trying to stretch them up could look
really
> bad.

Done. Thanks for explaining the reasons behind fudging

[commit-bot: I haz the power, 2017-02-01 19:11:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-01 19:15:05]

https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:571:
public static int getMinimumBadgeIconSizeInPx(Context context) {
Given that this function returns the exact same value as above, do you really
need both?

[F, 2017-02-01 19:27:06]

The CQ bit was checked by zpeng@chromium.org to run a CQ dry run

[F, 2017-02-01 19:27:19]

Thanks Dan, PTAL!

https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
(right):

https://codereview.chromium.org/2664983004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java:571:
public static int getMinimumBadgeIconSizeInPx(Context context) {
On 2017/02/01 19:15:04, dfalcantara (load balance plz) wrote:
> Given that this function returns the exact same value as above, do you really
> need both?

For consistency's sake, I'd like to keep both the ideal and the minimum.
However, I agree that the minimum function can be removed.

I removed the minimum function from the java and c++ code. WDUT?

[commit-bot: I haz the power, 2017-02-01 19:27:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gone, 2017-02-01 19:41:50]

lgtm

[F, 2017-02-01 19:44:43]

The CQ bit was unchecked by zpeng@chromium.org

[F, 2017-02-01 19:44:58]

The CQ bit was checked by zpeng@chromium.org

[commit-bot: I haz the power, 2017-02-01 19:45:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:54:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485978298290750,
"parent_rev": "38d35a679d1a31e2a7467e6971a41b58abbb679f", "commit_rev":
"e33ba85e0048b6998e3c7fbb02a6cece1ceae07b"}

[commit-bot: I haz the power, 2017-02-01 20:55:43]

Description was changed from

==========
Allow ShortcutHelper to retrieve badge icon dimensions.

Allow ShortcutHelper to retrieve minimum badge icon size and ideal
badge icon size. Ideal badge icon size comes from Android Developers
https://developer.android.com/guide/practices/ui_guidelines/icon_design_statu....

BUG=649771
==========

to

==========
Allow ShortcutHelper to retrieve badge icon dimensions.

Allow ShortcutHelper to retrieve minimum badge icon size and ideal
badge icon size. Ideal badge icon size comes from Android Developers
https://developer.android.com/guide/practices/ui_guidelines/icon_design_statu....

BUG=649771

Review-Url: https://codereview.chromium.org/2664983004
Cr-Commit-Position: refs/heads/master@{#447603}
Committed:
https://chromium.googlesource.com/chromium/src/+/e33ba85e0048b6998e3c7fbb02a6...
==========

[commit-bot: I haz the power, 2017-02-01 20:55:45]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e33ba85e0048b6998e3c7fbb02a6...