Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java

Issue 2664983004: Allow ShortcutHelper to retrieve badge icon dimensions. (Closed)
Patch Set: Addressing comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/browser/android/shortcut_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
index 9bb166773ac1199ec993a12a54d29685cb851db7..86c69141d79ba80056b577fd539a4469fcdc16f0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java
@@ -515,8 +515,8 @@ public class ShortcutHelper {
/**
* Returns the ideal size for an icon representing a web app. This size is used on app banners,
* the Android Home screen, and in Android's recent tasks list, among other places.
- * @param resources Resources to retrieve the dimension from.
- * @return the dimensions in dp which the icon should have.
+ * @param context Context to pull resources from.
+ * @return the dimensions in pixels which the icon should have.
*/
public static int getIdealHomescreenIconSizeInPx(Context context) {
return getSizeFromResourceInPx(context, R.dimen.webapp_home_screen_icon_size);
@@ -525,8 +525,8 @@ public class ShortcutHelper {
/**
* Returns the minimum size for an icon representing a web app. This size is used on app
* banners, the Android Home screen, and in Android's recent tasks list, among other places.
- * @param resources Resources to retrieve the dimension from.
- * @return the lower bound of the size which the icon should have in dp.
+ * @param context Context to pull resources from.
+ * @return the lower bound of the size which the icon should have in pixels.
*/
public static int getMinimumHomescreenIconSizeInPx(Context context) {
float sizeInPx = context.getResources().getDimension(R.dimen.webapp_home_screen_icon_size);
@@ -538,8 +538,8 @@ public class ShortcutHelper {
/**
* Returns the ideal size for an image displayed on a web app's splash screen.
- * @param resources Resources to retrieve the dimension from.
- * @return the dimensions in dp which the image should have.
+ * @param context Context to pull resources from.
+ * @return the dimensions in pixels which the image should have.
*/
public static int getIdealSplashImageSizeInPx(Context context) {
return getSizeFromResourceInPx(context, R.dimen.webapp_splash_image_size_ideal);
@@ -547,14 +547,23 @@ public class ShortcutHelper {
/**
* Returns the minimum size for an image displayed on a web app's splash screen.
- * @param resources Resources to retrieve the dimension from.
- * @return the lower bound of the size which the image should have in dp.
+ * @param context Context to pull resources from.
+ * @return the lower bound of the size which the image should have in pixels.
*/
public static int getMinimumSplashImageSizeInPx(Context context) {
return getSizeFromResourceInPx(context, R.dimen.webapp_splash_image_size_minimum);
}
/**
+ * Returns the ideal size for a badge icon of a WebAPK.
+ * @param context Context to pull resources from.
+ * @return the dimensions in pixels which the badge icon should have.
+ */
+ public static int getIdealBadgeIconSizeInPx(Context context) {
+ return getSizeFromResourceInPx(context, R.dimen.webapk_badge_icon_size);
+ }
+
+ /**
* @return String that can be used to verify that a WebappActivity is being started by Chrome.
*/
public static String getEncodedMac(Context context, String url) {
@@ -611,7 +620,8 @@ public class ShortcutHelper {
getIdealHomescreenIconSizeInPx(context),
getMinimumHomescreenIconSizeInPx(context),
getIdealSplashImageSizeInPx(context),
- getMinimumSplashImageSizeInPx(context)
+ getMinimumSplashImageSizeInPx(context),
+ getIdealBadgeIconSizeInPx(context)
};
}
« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/browser/android/shortcut_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698