Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2664983003: Revert of Roll buildtools a7cc7a3e21..c302711306 (Closed)

Created:
3 years, 10 months ago by sdefresne
Modified:
3 years, 10 months ago
Reviewers:
Nico, Dan Beam
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll buildtools a7cc7a3e21..c302711306 (patchset #2 id:20001 of https://codereview.chromium.org/2659853002/ ) Reason for revert: Breaks presubmit for Objective-C code formatting in src/ios (due to https://bugs.chromium.org/p/chromium/issues/detail?id=686650). Original issue's description: > Roll buildtools a7cc7a3e21..c302711306 to pick up new clang-format binaries: > > c302711306 Update clang-format binaries and scripts for all platforms (take 2). > a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." > 99df659c6e Update clang-format binaries and scripts for all platforms. > df89892622 Fix "Updating clang-format" wiki link > > R=thakis@chromium.org > BUG=567770 > > Review-Url: https://codereview.chromium.org/2659853002 > Cr-Commit-Position: refs/heads/master@{#446842} > Committed: https://chromium.googlesource.com/chromium/src/+/c380d9c4c0fbde77570427d8d8b11a4759652bf2 TBR=thakis@chromium.org,dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=567770, 686650 Review-Url: https://codereview.chromium.org/2664983003 Cr-Commit-Position: refs/heads/master@{#447219} Committed: https://chromium.googlesource.com/chromium/src/+/9afca38d59c642849c76fab7e623e9f6df8926fe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
sdefresne
Created Revert of Roll buildtools a7cc7a3e21..c302711306
3 years, 10 months ago (2017-01-31 11:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664983003/1
3 years, 10 months ago (2017-01-31 11:13:50 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 12:19:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9afca38d59c642849c76fab7e623...

Powered by Google App Engine
This is Rietveld 408576698