|
|
Chromium Code Reviews
DescriptionRoll buildtools a7cc7a3e21..c302711306 to pick up new clang-format binaries:
c302711306 Update clang-format binaries and scripts for all platforms (take 2).
a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms."
99df659c6e Update clang-format binaries and scripts for all platforms.
df89892622 Fix "Updating clang-format" wiki link
R=thakis@chromium.org
BUG=567770
Review-Url: https://codereview.chromium.org/2659853002
Cr-Commit-Position: refs/heads/master@{#446842}
Committed: https://chromium.googlesource.com/chromium/src/+/c380d9c4c0fbde77570427d8d8b11a4759652bf2
Patch Set 1 #Patch Set 2 : merge #Messages
Total messages: 17 (11 generated)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2017/01/27 02:53:43, Dan Beam wrote: Brett sent an email about that gn update earlier, you probably need to sync and rebase. Then LGTM
Description was changed from ========== Roll buildtools 8e94621c36..c302711306 Mainly to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link a7cc7a3e21 Roll gn f13158d3c5..d8754536ca (r445411:r446079) R=thakis@chromium.org BUG=567770 ========== to ========== Roll buildtools 8e94621c36..c302711306 Mainly to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 ==========
Description was changed from ========== Roll buildtools 8e94621c36..c302711306 Mainly to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 ========== to ========== Roll buildtools a7cc7a3e21..c302711306 Mainly to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 ==========
On 2017/01/27 03:47:01, Nico wrote: > On 2017/01/27 02:53:43, Dan Beam wrote: > > Brett sent an email about that gn update earlier, you probably need to sync and > rebase. Then LGTM merged and updated CL desc (now rolling from a7cc7a3e21a061975b33dcdcd81a9716ba614c3c, which is more current)
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2659853002/#ps20001 (title: "merge")
Description was changed from ========== Roll buildtools a7cc7a3e21..c302711306 Mainly to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 ========== to ========== Roll buildtools a7cc7a3e21..c302711306 to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485556591326750,
"parent_rev": "06b3cc2e67bcf90b513364729118927b08aacada", "commit_rev":
"c380d9c4c0fbde77570427d8d8b11a4759652bf2"}
Message was sent while issue was closed.
Description was changed from ========== Roll buildtools a7cc7a3e21..c302711306 to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 ========== to ========== Roll buildtools a7cc7a3e21..c302711306 to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 Review-Url: https://codereview.chromium.org/2659853002 Cr-Commit-Position: refs/heads/master@{#446842} Committed: https://chromium.googlesource.com/chromium/src/+/c380d9c4c0fbde77570427d8d8b1... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c380d9c4c0fbde77570427d8d8b1...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2664983003/ by sdefresne@chromium.org. The reason for reverting is: Breaks presubmit for Objective-C code formatting in src/ios (due to https://bugs.chromium.org/p/chromium/issues/detail?id=686650).. |
