Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 2659853002: Roll buildtools a7cc7a3e21..c302711306 (Closed)

Created:
3 years, 10 months ago by Dan Beam
Modified:
3 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll buildtools a7cc7a3e21..c302711306 to pick up new clang-format binaries: c302711306 Update clang-format binaries and scripts for all platforms (take 2). a2ace8b013 Revert "Update clang-format binaries and scripts for all platforms." 99df659c6e Update clang-format binaries and scripts for all platforms. df89892622 Fix "Updating clang-format" wiki link R=thakis@chromium.org BUG=567770 Review-Url: https://codereview.chromium.org/2659853002 Cr-Commit-Position: refs/heads/master@{#446842} Committed: https://chromium.googlesource.com/chromium/src/+/c380d9c4c0fbde77570427d8d8b11a4759652bf2

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Dan Beam
3 years, 10 months ago (2017-01-27 02:53:43 UTC) #1
Nico
On 2017/01/27 02:53:43, Dan Beam wrote: Brett sent an email about that gn update earlier, ...
3 years, 10 months ago (2017-01-27 03:47:01 UTC) #6
Dan Beam
On 2017/01/27 03:47:01, Nico wrote: > On 2017/01/27 02:53:43, Dan Beam wrote: > > Brett ...
3 years, 10 months ago (2017-01-27 22:36:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659853002/20001
3 years, 10 months ago (2017-01-27 22:37:36 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c380d9c4c0fbde77570427d8d8b11a4759652bf2
3 years, 10 months ago (2017-01-28 00:05:10 UTC) #16
sdefresne
3 years, 10 months ago (2017-01-31 11:13:34 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2664983003/ by sdefresne@chromium.org.

The reason for reverting is: Breaks presubmit for Objective-C code formatting in
src/ios (due to https://bugs.chromium.org/p/chromium/issues/detail?id=686650)..

Powered by Google App Engine
This is Rietveld 408576698