mus: Make --use-mus-in-renderer the default for --mash.

mus: Make --use-mus-in-renderer the default for --mash.

In mus, we want the renderer to be a mus client. So Make that the
default option. Keep an escape hatch --no-use-mus-in-renderer for a
few days before we remove the alternate option.

BUG=686235
Review-Url: https://codereview.chromium.org/2664963002
Cr-Commit-Position: refs/heads/master@{#447275}
Committed: https://chromium.googlesource.com/chromium/src/+/8185d9772224f42c18c942e8932441fe3ec025d7

[sadrul, 2017-01-30 21:43:02]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-01-30 21:43:52]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-01-30 21:44:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 22:11:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 22:11:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2017-01-31 04:17:30]

LGTM

https://codereview.chromium.org/2664963002/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2664963002/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:1471: if (env_.get() &&
env_.get() -> env_.
Also, Env::GetInstance() really be null here?

https://codereview.chromium.org/2664963002/diff/1/content/public/common/conte...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2664963002/diff/1/content/public/common/conte...
content/public/common/content_switches.cc:678: // Use the mojo UI Service in the
Chrome render process.
Don't use.

[sadrul, 2017-01-31 15:39:14]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 15:39:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-31 15:45:12]

sadrul@chromium.org changed reviewers:
+ jam@chromium.org

[sadrul, 2017-01-31 15:45:13]

+jam@ for content/renderer. Also, for owner of the rest.

https://codereview.chromium.org/2664963002/diff/1/content/browser/browser_mai...
File content/browser/browser_main_loop.cc (right):

https://codereview.chromium.org/2664963002/diff/1/content/browser/browser_mai...
content/browser/browser_main_loop.cc:1471: if (env_.get() &&
On 2017/01/31 04:17:30, sky wrote:
> env_.get() -> env_.
> Also, Env::GetInstance() really be null here?

I don't think so. I have removed this check.

https://codereview.chromium.org/2664963002/diff/1/content/public/common/conte...
File content/public/common/content_switches.cc (right):

https://codereview.chromium.org/2664963002/diff/1/content/public/common/conte...
content/public/common/content_switches.cc:678: // Use the mojo UI Service in the
Chrome render process.
On 2017/01/31 04:17:30, sky wrote:
> Don't use.

Oops. Done.

[jam, 2017-01-31 16:06:50]

lgtm

https://codereview.chromium.org/2664963002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2664963002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:1879:
switches::kNoUseMusInRenderer,
nit: pattern here is to put switches not in ifdef sorted above, then end with
ifdefs. so move this up

[commit-bot: I haz the power, 2017-01-31 16:50:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 16:50:15]

Dry run: This issue passed the CQ dry run.

[sadrul, 2017-01-31 17:00:53]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-01-31 17:01:05]

https://codereview.chromium.org/2664963002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/2664963002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:1879:
switches::kNoUseMusInRenderer,
On 2017/01/31 16:06:50, jam wrote:
> nit: pattern here is to put switches not in ifdef sorted above, then end with
> ifdefs. so move this up

Done.

[commit-bot: I haz the power, 2017-01-31 17:01:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-01-31 17:59:09]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2017-01-31 17:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/2664963002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-01-31 17:59:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 18:30:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485885549436180,
"parent_rev": "e6b51b8a4e230ca0100e927a48cabbae0e4cf70b", "commit_rev":
"8185d9772224f42c18c942e8932441fe3ec025d7"}

[commit-bot: I haz the power, 2017-01-31 18:30:53]

Description was changed from

==========
mus: Make --use-mus-in-renderer the default for --mash.

In mus, we want the renderer to be a mus client. So Make that the
default option. Keep an escape hatch --no-use-mus-in-renderer for a
few days before we remove the alternate option.

BUG=686235
==========

to

==========
mus: Make --use-mus-in-renderer the default for --mash.

In mus, we want the renderer to be a mus client. So Make that the
default option. Keep an escape hatch --no-use-mus-in-renderer for a
few days before we remove the alternate option.

BUG=686235

Review-Url: https://codereview.chromium.org/2664963002
Cr-Commit-Position: refs/heads/master@{#447275}
Committed:
https://chromium.googlesource.com/chromium/src/+/8185d9772224f42c18c942e89324...
==========

[commit-bot: I haz the power, 2017-01-31 18:30:54]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8185d9772224f42c18c942e89324...