Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8542)

Unified Diff: content/renderer/render_widget.cc

Issue 2664963002: mus: Make --use-mus-in-renderer the default for --mash. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/render_widget_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index d9edfea44b72f0dc3fcb4a0e2dc05dec9d3df7b1..32caa60d16d1a89d9474f652401f0334fa74dbe0 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -389,8 +389,8 @@ RenderWidget::RenderWidget(int32_t widget_routing_id,
render_widget_scheduling_state_->SetHidden(is_hidden_);
}
#if defined(USE_AURA)
- if (base::CommandLine::ForCurrentProcess()->HasSwitch(
- switches::kUseMusInRenderer)) {
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kNoUseMusInRenderer)) {
RendererWindowTreeClient::Create(routing_id_);
}
#endif
@@ -402,6 +402,15 @@ RenderWidget::~RenderWidget() {
// If we are swapped out, we have released already.
if (!is_swapped_out_ && RenderProcess::current())
RenderProcess::current()->ReleaseProcess();
+#if defined(USE_AURA)
+ if (!base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kNoUseMusInRenderer)) {
+ // It is possible for a RenderWidget to be destroyed before it was embedded
+ // in a mus window. The RendererWindowTreeClient will leak in such cases. So
+ // explicitly delete it here.
+ RendererWindowTreeClient::Destroy(routing_id_);
+ }
+#endif
}
// static
« no previous file with comments | « content/renderer/render_thread_impl.cc ('k') | content/renderer/render_widget_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698