Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 266483003: [WebSocket] Do nothing for connect() if initialization has failed. (Closed)

Created:
6 years, 7 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 7 months ago
Reviewers:
yhirano
CC:
blink-reviews
Visibility:
Public.

Description

[WebSocket] Do nothing for connect() if initialization has failed. m_syncHelper will be 0 if initialize() fails. connect() must just return with false in such case. BUG=368329 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172973

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 7 months ago (2014-04-30 07:04:55 UTC) #1
yhirano
https://codereview.chromium.org/266483003/diff/1/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp File Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp (right): https://codereview.chromium.org/266483003/diff/1/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp#newcode493 Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp:493: if (!m_workerGlobalScope) m_syncHelper?
6 years, 7 months ago (2014-04-30 07:17:08 UTC) #2
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/266483003/diff/1/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp File Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp (right): https://codereview.chromium.org/266483003/diff/1/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp#newcode493 Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp:493: if (!m_workerGlobalScope) On 2014/04/30 07:17:08, yhirano wrote: > m_syncHelper? ...
6 years, 7 months ago (2014-04-30 07:36:23 UTC) #3
yhirano
lgtm
6 years, 7 months ago (2014-04-30 08:14:24 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 7 months ago (2014-04-30 10:45:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/266483003/1
6 years, 7 months ago (2014-04-30 10:45:35 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 11:46:41 UTC) #7
Message was sent while issue was closed.
Change committed as 172973

Powered by Google App Engine
This is Rietveld 408576698