[WebSocket] Do nothing for connect() if initialization has failed.

Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp

 /*
  * Copyright (C) 2011, 2012 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 472 matching lines @@
     m_loaderProxy.postTaskToLoader(createCallbackTask(&Peer::initialize, reference.release(), AllowCrossThreadAccess(&m_loaderProxy), m_workerClientWrapper, sourceURL, lineNumber, syncHelper.release()));
     if (!waitForMethodCompletion()) {
         // The worker thread has been signalled to shutdown before method completion.
         terminatePeer();
     }
 }
 
 bool WorkerThreadableWebSocketChannel::Bridge::connect(const KURL& url, const String& protocol)
 {
     ASSERT(m_workerClientWrapper);
+    if (!m_workerGlobalScope)

[yhirano, 2014/04/30 07:17:08]

m_syncHelper?

[tyoshino (SeeGerritForStatus), 2014/04/30 07:36:23]

m_workerGlobalScope can also tell whether initialize() was successful or not.
I'd like to keep this consistent with the rest of methods below and refactor
later. Re: m_workerClientWrapper, I already have CL for removing it so let me
omit only m_workerClientWrapper.

+        return false;
+    ASSERT(m_syncHelper);
     m_loaderProxy.postTaskToLoader(CallClosureTask::create(bind(&Peer::connect, m_peer, url.copy(), protocol.isolatedCopy())));
     RefPtr<Bridge> protect(this);
     waitForMethodCompletion();
     return m_syncHelper->connectRequestResult();
 }
 
 WebSocketChannel::SendResult WorkerThreadableWebSocketChannel::Bridge::send(const String& message)
 {
     if (!m_workerClientWrapper || !m_workerGlobalScope)
         return WebSocketChannel::SendFail;
@@ skipping 91 matching lines @@
 }
 
 void WorkerThreadableWebSocketChannel::Bridge::terminatePeer()
 {
     m_loaderProxy.postTaskToLoader(CallClosureTask::create(bind(&Peer::destroy, m_peer)));
     m_workerGlobalScope = nullptr;
     m_syncHelper = 0;
 }
 
 } // namespace WebCore