Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1368)

Unified Diff: Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp

Issue 266483003: [WebSocket] Do nothing for connect() if initialization has failed. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp
diff --git a/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp b/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp
index 705b99d0087a20c063f983878c68d6e16aa7233e..3fb04f773687d1114e736fddbb2420ac7e70cde2 100644
--- a/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp
+++ b/Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp
@@ -490,6 +490,9 @@ void WorkerThreadableWebSocketChannel::Bridge::initialize(const String& sourceUR
bool WorkerThreadableWebSocketChannel::Bridge::connect(const KURL& url, const String& protocol)
{
ASSERT(m_workerClientWrapper);
+ if (!m_workerGlobalScope)
yhirano 2014/04/30 07:17:08 m_syncHelper?
tyoshino (SeeGerritForStatus) 2014/04/30 07:36:23 m_workerGlobalScope can also tell whether initiali
+ return false;
+ ASSERT(m_syncHelper);
m_loaderProxy.postTaskToLoader(CallClosureTask::create(bind(&Peer::connect, m_peer, url.copy(), protocol.isolatedCopy())));
RefPtr<Bridge> protect(this);
waitForMethodCompletion();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698