Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2664783002: [Test] Perform warmup first on SixSpeed super_spread benchmarks. (Closed)

Created:
3 years, 10 months ago by petermarshall
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer, Franzi
CC:
v8-reviews_googlegroups.com, Benedikt Meurer
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Test] Perform warmup first on SixSpeed super_spread benchmarks. The graphs don't show any performance bump for https://codereview.chromium.org/2659623002, which I do see a much better result for locally. I suspect the function isn't being optimized in turbofan when the benchmarks run. Maybe this warmup flag will trigger that. BUG=v8:5895 Review-Url: https://codereview.chromium.org/2664783002 Cr-Commit-Position: refs/heads/master@{#42776} Committed: https://chromium.googlesource.com/v8/v8/+/f87ce44f527c1c96a25e7e6df0bc0d4f829a1d90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M test/js-perf-test/SixSpeed/super_spread/run.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
petermarshall
PTAL =]
3 years, 10 months ago (2017-01-30 13:13:14 UTC) #5
Benedikt Meurer
lgtm
3 years, 10 months ago (2017-01-30 13:13:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664783002/1
3 years, 10 months ago (2017-01-30 13:57:23 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 13:59:05 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/f87ce44f527c1c96a25e7e6df0bc0d4f829...

Powered by Google App Engine
This is Rietveld 408576698