[turbofan] Reduce CallConstructWithSpread where iteration is not observable.

[turbofan] Reduce CallConstructWithSpread where iteration is not observable.

Where the arguments have already been inlined, we can replace these calls with a
direct call to construct. We have to make sure that the iteration over the arguments is not observable.

BUG=v8:5895
Review-Url: https://codereview.chromium.org/2659623002
Cr-Commit-Position: refs/heads/master@{#42765}
Committed: https://chromium.googlesource.com/v8/v8/+/409d018005ab42ea664e7843e67676544b5b956b

[petermarshall, 2017-01-27 13:43:39]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-27 13:43:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 14:17:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 14:17:33]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2017-01-30 08:39:27]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-30 08:39:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[petermarshall, 2017-01-30 08:42:24]

Description was changed from

==========
[Turbo] Add dependency on map and test for modifying next on iterator proto.

BUG=v8:5895
==========

to

==========
[Turbo] Reduce CallConstructWithSpread where iteration is not observable.

Where the arguments have already been inlined, we can replace these calls with a
direct call to construct. We have to make sure that the iteration over the
arguments is not observable.

BUG=v8:5895
==========

[petermarshall, 2017-01-30 08:42:53]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org

[petermarshall, 2017-01-30 08:42:54]

PTAL =]. Do you think there are any other test cases we need, or
dependencies/checks to add in the reducer?

[petermarshall, 2017-01-30 08:48:39]

Also, when we do ChangeOp to CallConstruct, what can we do about the call
frequency parameter? We don't collect this info for CallConstructWithSpread.

[petermarshall, 2017-01-30 08:50:26]

Description was changed from

==========
[Turbo] Reduce CallConstructWithSpread where iteration is not observable.

Where the arguments have already been inlined, we can replace these calls with a
direct call to construct. We have to make sure that the iteration over the
arguments is not observable.

BUG=v8:5895
==========

to

==========
[turbofan] Reduce CallConstructWithSpread where iteration is not observable.

Where the arguments have already been inlined, we can replace these calls with a
direct call to construct. We have to make sure that the iteration over the
arguments is not observable.

BUG=v8:5895
==========

[Benedikt Meurer, 2017-01-30 09:14:16]

LGTM % nits

https://codereview.chromium.org/2659623002/diff/40001/src/compiler/js-call-re...
File src/compiler/js-call-reducer.cc (right):

https://codereview.chromium.org/2659623002/diff/40001/src/compiler/js-call-re...
src/compiler/js-call-reducer.cc:742: // Add a code dependency on the string
length overflow protector.
Typo: string length overflow :-)

https://codereview.chromium.org/2659623002/diff/40001/src/compiler/js-call-re...
src/compiler/js-call-reducer.cc:747: if
(!isolate()->initial_array_iterator_prototype_map()->is_stable()) {
This should be done earlier, before you add dependencies.

[commit-bot: I haz the power, 2017-01-30 09:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-30 09:15:31]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2017-01-30 09:43:58]

Thanks

https://codereview.chromium.org/2659623002/diff/40001/src/compiler/js-call-re...
File src/compiler/js-call-reducer.cc (right):

https://codereview.chromium.org/2659623002/diff/40001/src/compiler/js-call-re...
src/compiler/js-call-reducer.cc:742: // Add a code dependency on the string
length overflow protector.
On 2017/01/30 at 09:14:16, Benedikt Meurer wrote:
> Typo: string length overflow :-)

Done

https://codereview.chromium.org/2659623002/diff/40001/src/compiler/js-call-re...
src/compiler/js-call-reducer.cc:747: if
(!isolate()->initial_array_iterator_prototype_map()->is_stable()) {
On 2017/01/30 at 09:14:16, Benedikt Meurer wrote:
> This should be done earlier, before you add dependencies.

Done

[petermarshall, 2017-01-30 09:59:09]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2017-01-30 09:59:10]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2659623002/#ps60001
(title: "respond to comments from Benedikt")

[commit-bot: I haz the power, 2017-01-30 09:59:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 10:29:06]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485770349919320,
"parent_rev": "ccf428bb0473cf894bf1adae286917ba6156d376", "commit_rev":
"409d018005ab42ea664e7843e67676544b5b956b"}

[commit-bot: I haz the power, 2017-01-30 10:29:12]

Description was changed from

==========
[turbofan] Reduce CallConstructWithSpread where iteration is not observable.

Where the arguments have already been inlined, we can replace these calls with a
direct call to construct. We have to make sure that the iteration over the
arguments is not observable.

BUG=v8:5895
==========

to

==========
[turbofan] Reduce CallConstructWithSpread where iteration is not observable.

Where the arguments have already been inlined, we can replace these calls with a
direct call to construct. We have to make sure that the iteration over the
arguments is not observable.

BUG=v8:5895

Review-Url: https://codereview.chromium.org/2659623002
Cr-Commit-Position: refs/heads/master@{#42765}
Committed:
https://chromium.googlesource.com/v8/v8/+/409d018005ab42ea664e7843e67676544b5...
==========

[commit-bot: I haz the power, 2017-01-30 10:29:13]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/409d018005ab42ea664e7843e67676544b5...