extensions/shell/browser/api/identity/identity_api.cc - Issue 2664753002: Remove base::StringValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/api/identity/identity_api.cc

Issue 2664753002: Remove base::StringValue (Closed)

Patch Set: Rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/shell/browser/api/identity/identity_api.cc

diff --git a/extensions/shell/browser/api/identity/identity_api.cc b/extensions/shell/browser/api/identity/identity_api.cc

index b2b057c6c95a9dd50adf29eb0ee106826f3a3a3e..c1eccfd027c81699797fd30ea2f18227abdd8443 100644

--- a/extensions/shell/browser/api/identity/identity_api.cc

+++ b/extensions/shell/browser/api/identity/identity_api.cc

@@ -127,7 +127,7 @@ void IdentityGetAuthTokenFunction::OnGetTokenFailure(

void IdentityGetAuthTokenFunction::OnMintTokenSuccess(

const std::string& access_token,

int time_to_live) {

- Respond(OneArgument(base::MakeUnique<base::StringValue>(access_token)));

+ Respond(OneArgument(base::MakeUnique<base::Value>(access_token)));

Release(); // Balanced in Run().

}