Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: extensions/common/value_builder.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/url_pattern_set.cc ('k') | extensions/renderer/activity_log_converter_strategy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/value_builder.cc
diff --git a/extensions/common/value_builder.cc b/extensions/common/value_builder.cc
index 08bb7de1e1e85f816cd6696af1cf95795d3ce4e2..7f2a177e4db371f46312b4553fc116d77e762e2d 100644
--- a/extensions/common/value_builder.cc
+++ b/extensions/common/value_builder.cc
@@ -42,15 +42,13 @@ DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
const std::string& in_value) {
- dict_->SetWithoutPathExpansion(path,
- base::MakeUnique<base::StringValue>(in_value));
+ dict_->SetWithoutPathExpansion(path, base::MakeUnique<base::Value>(in_value));
return *this;
}
DictionaryBuilder& DictionaryBuilder::Set(const std::string& path,
const base::string16& in_value) {
- dict_->SetWithoutPathExpansion(path,
- base::MakeUnique<base::StringValue>(in_value));
+ dict_->SetWithoutPathExpansion(path, base::MakeUnique<base::Value>(in_value));
return *this;
}
« no previous file with comments | « extensions/common/url_pattern_set.cc ('k') | extensions/renderer/activity_log_converter_strategy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698