Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: extensions/browser/value_store/leveldb_value_store_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/leveldb_value_store_unittest.cc
diff --git a/extensions/browser/value_store/leveldb_value_store_unittest.cc b/extensions/browser/value_store/leveldb_value_store_unittest.cc
index 8498409ef69ff444a12374b7567578a89b95d62f..4cb1151ec377f3bb4a380d36320254f2976901df 100644
--- a/extensions/browser/value_store/leveldb_value_store_unittest.cc
+++ b/extensions/browser/value_store/leveldb_value_store_unittest.cc
@@ -75,7 +75,7 @@ TEST_F(LeveldbValueStoreUnitTest, RestoreKeyTest) {
const char kValue[] = "value";
// Insert a valid pair.
- std::unique_ptr<base::Value> value(new base::StringValue(kValue));
+ std::unique_ptr<base::Value> value(new base::Value(kValue));
ASSERT_TRUE(store()
->Set(ValueStore::DEFAULTS, kNotCorruptKey, *value)
->status().ok());
@@ -117,7 +117,7 @@ TEST_F(LeveldbValueStoreUnitTest, RestoreDoesMinimumNecessary) {
const char kCorruptValue[] = "[{(.*+\"\'\\";
// Insert a collection of non-corrupted pairs.
- std::unique_ptr<base::Value> value(new base::StringValue(kValue));
+ std::unique_ptr<base::Value> value(new base::Value(kValue));
for (size_t i = 0; i < kNotCorruptKeysSize; ++i) {
ASSERT_TRUE(store()
->Set(ValueStore::DEFAULTS, kNotCorruptKeys[i], *value)
@@ -163,7 +163,7 @@ TEST_F(LeveldbValueStoreUnitTest, RestoreFullDatabase) {
const char kValue[] = "value";
// Generate a database.
- std::unique_ptr<base::Value> value(new base::StringValue(kValue));
+ std::unique_ptr<base::Value> value(new base::Value(kValue));
for (size_t i = 0; i < kNotCorruptKeysSize; ++i) {
ASSERT_TRUE(store()
->Set(ValueStore::DEFAULTS, kNotCorruptKeys[i], *value)

Powered by Google App Engine
This is Rietveld 408576698