Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Unified Diff: extensions/browser/api/test/test_api.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/test/test_api.cc
diff --git a/extensions/browser/api/test/test_api.cc b/extensions/browser/api/test/test_api.cc
index 2eefdaf929ec57108f73a447996968cec7871387..7bd4372b1772e017ccc2f48d7a1bb0f40b164bfe 100644
--- a/extensions/browser/api/test/test_api.cc
+++ b/extensions/browser/api/test/test_api.cc
@@ -97,8 +97,7 @@ ExtensionFunction::ResponseAction TestSendMessageFunction::Run() {
// finish the function.
if (!listener_will_respond || response_.get()) {
if (!response_) {
- response_ =
- OneArgument(base::MakeUnique<base::StringValue>(std::string()));
+ response_ = OneArgument(base::MakeUnique<base::Value>(std::string()));
}
return RespondNow(std::move(response_));
}
@@ -111,7 +110,7 @@ TestSendMessageFunction::~TestSendMessageFunction() {}
void TestSendMessageFunction::Reply(const std::string& message) {
DCHECK(!response_);
- response_ = OneArgument(base::MakeUnique<base::StringValue>(message));
+ response_ = OneArgument(base::MakeUnique<base::Value>(message));
if (waiting_)
Respond(std::move(response_));
}
@@ -155,7 +154,7 @@ ExtensionFunction::ResponseAction TestWaitForRoundTripFunction::Run() {
std::unique_ptr<WaitForRoundTrip::Params> params(
WaitForRoundTrip::Params::Create(*args_));
return RespondNow(
- OneArgument(base::MakeUnique<base::StringValue>(params->message)));
+ OneArgument(base::MakeUnique<base::Value>(params->message)));
}
} // namespace extensions
« no previous file with comments | « extensions/browser/api/system_storage/system_storage_api.cc ('k') | extensions/browser/api/vpn_provider/vpn_provider_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698