Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc

Issue 2664753002: Remove base::StringValue (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
diff --git a/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc b/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
index 987dae07aff29341466818dda742f5241b65dafb..423d40114bd936db10282e4abdec8a39afeb3951 100644
--- a/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
+++ b/components/policy/core/common/cloud/component_cloud_policy_service_unittest.cc
@@ -128,12 +128,12 @@ class ComponentCloudPolicyServiceTest : public testing::Test {
public_key_ = builder_.GetPublicSigningKeyAsString();
- expected_policy_.Set(
- "Name", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER, POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("disabled"), nullptr);
+ expected_policy_.Set("Name", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
+ POLICY_SOURCE_CLOUD,
+ base::MakeUnique<base::Value>("disabled"), nullptr);
expected_policy_.Set("Second", POLICY_LEVEL_RECOMMENDED, POLICY_SCOPE_USER,
POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("maybe"), nullptr);
+ base::MakeUnique<base::Value>("maybe"), nullptr);
}
void SetUp() override {
@@ -596,8 +596,8 @@ TEST_F(ComponentCloudPolicyServiceTest, LoadInvalidPolicyFromCache) {
PolicyBundle expected_bundle;
expected_bundle.Get(kTestExtensionNS)
.Set("Name", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
- POLICY_SOURCE_CLOUD,
- base::MakeUnique<base::StringValue>("published"), nullptr);
+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>("published"),
+ nullptr);
EXPECT_TRUE(service_->policy().Equals(expected_bundle));
}

Powered by Google App Engine
This is Rietveld 408576698