Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2664703002: Move purging from OnMemoryState to OnPurgeMemory() in cc/ (Closed)

Created:
3 years, 10 months ago by bashi
Modified:
3 years, 10 months ago
Reviewers:
tasak, ericrk
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move purging from OnMemoryState to OnPurgeMemory() in cc/ We are going to separate memory purging logic from memory state changes. This CL moves purging from OnMemoryState() to OnPurgeMemory() in cc/. BUG=684287 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2664703002 Cr-Commit-Position: refs/heads/master@{#449484} Committed: https://chromium.googlesource.com/chromium/src/+/c841b76ac7d8465283eb13e87d05388004a6f6bf

Patch Set 1 #

Total comments: 4

Patch Set 2 : Don't call OnPurgeMemory() in OnStateChange() #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -64 lines) Patch
M cc/raster/staging_buffer_pool.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/raster/staging_buffer_pool.cc View 1 1 chunk +4 lines, -18 lines 0 comments Download
M cc/resources/resource_pool.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource_pool.cc View 1 1 chunk +3 lines, -17 lines 0 comments Download
M cc/resources/resource_pool_unittest.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/tiles/gpu_image_decode_cache.cc View 1 2 chunks +10 lines, -18 lines 4 comments Download
M cc/tiles/gpu_image_decode_cache_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M cc/tiles/software_image_decode_cache.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/tiles/software_image_decode_cache.cc View 1 3 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
bashi
tasak@: could you check this CL doesn't break your purge+suspend experiment?
3 years, 10 months ago (2017-01-30 02:06:39 UTC) #5
tasak
lgtm
3 years, 10 months ago (2017-01-30 02:17:10 UTC) #6
bashi
ericrk@: PTAL?
3 years, 10 months ago (2017-01-30 02:44:20 UTC) #8
ericrk
Just so I can better understand what is changing - will there still be a ...
3 years, 10 months ago (2017-01-30 15:58:56 UTC) #11
bashi
Thank you for review! Sorry for lack of explanations. I should have provided the context. ...
3 years, 10 months ago (2017-01-31 19:30:56 UTC) #12
ericrk
lgtm Thanks for explaining. This makes sense with the current explanations. THROTTLED might be a ...
3 years, 10 months ago (2017-02-05 06:26:22 UTC) #13
bashi
I've submitted https://codereview.chromium.org/2669323002/ and now we call both OnMemoryState(SUSPENDED) and OnPurgeMemory() when suspending so clients ...
3 years, 10 months ago (2017-02-07 00:58:59 UTC) #14
ericrk
https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc File cc/tiles/gpu_image_decode_cache.cc (right): https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc#newcode1280 cc/tiles/gpu_image_decode_cache.cc:1280: EnsureCapacity(0); On 2017/02/07 00:58:59, bashi wrote: > It seems ...
3 years, 10 months ago (2017-02-07 19:20:14 UTC) #15
bashi
https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc File cc/tiles/gpu_image_decode_cache.cc (right): https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc#newcode1280 cc/tiles/gpu_image_decode_cache.cc:1280: EnsureCapacity(0); On 2017/02/07 19:20:14, ericrk wrote: > On 2017/02/07 ...
3 years, 10 months ago (2017-02-09 00:46:18 UTC) #16
ericrk
still LGTM https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc File cc/tiles/gpu_image_decode_cache.cc (right): https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc#newcode1280 cc/tiles/gpu_image_decode_cache.cc:1280: EnsureCapacity(0); On 2017/02/09 00:46:18, bashi wrote: > ...
3 years, 10 months ago (2017-02-09 18:36:30 UTC) #17
bashi
On 2017/02/09 18:36:30, ericrk wrote: > still LGTM > > https://codereview.chromium.org/2664703002/diff/20001/cc/tiles/gpu_image_decode_cache.cc > File cc/tiles/gpu_image_decode_cache.cc (right): ...
3 years, 10 months ago (2017-02-09 23:00:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664703002/20001
3 years, 10 months ago (2017-02-09 23:01:31 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 00:16:34 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c841b76ac7d8465283eb13e87d05...

Powered by Google App Engine
This is Rietveld 408576698