Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: cc/resources/resource_pool_unittest.cc

Issue 2664703002: Move purging from OnMemoryState to OnPurgeMemory() in cc/ (Closed)
Patch Set: Don't call OnPurgeMemory() in OnStateChange() Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/resources/resource_pool_unittest.cc
diff --git a/cc/resources/resource_pool_unittest.cc b/cc/resources/resource_pool_unittest.cc
index 3b1c5b7e0450cd333a479fe952d443d47ba2452c..aa8e853e0c4f9caa95eda9cd1c30e7fc374f6002 100644
--- a/cc/resources/resource_pool_unittest.cc
+++ b/cc/resources/resource_pool_unittest.cc
@@ -353,7 +353,8 @@ TEST_F(ResourcePoolTest, MemoryStateSuspended) {
EXPECT_EQ(1u, resource_pool_->GetTotalResourceCountForTesting());
EXPECT_EQ(0u, resource_pool_->GetBusyResourceCountForTesting());
- // Suspending should not impact an in-use resource.
+ // Purging and suspending should not impact an in-use resource.
+ resource_pool_->OnPurgeMemory();
resource_pool_->OnMemoryStateChange(base::MemoryState::SUSPENDED);
EXPECT_EQ(1u, resource_pool_->GetTotalResourceCountForTesting());
EXPECT_EQ(0u, resource_pool_->GetBusyResourceCountForTesting());
@@ -364,7 +365,8 @@ TEST_F(ResourcePoolTest, MemoryStateSuspended) {
EXPECT_EQ(1u, resource_pool_->GetTotalResourceCountForTesting());
EXPECT_EQ(1u, resource_pool_->GetBusyResourceCountForTesting());
- // Suspending should now free the busy resource.
+ // Purging and suspending should now free the busy resource.
+ resource_pool_->OnPurgeMemory();
resource_pool_->OnMemoryStateChange(base::MemoryState::SUSPENDED);
EXPECT_EQ(0u, resource_pool_->GetTotalResourceCountForTesting());
EXPECT_EQ(0u, resource_pool_->GetBusyResourceCountForTesting());

Powered by Google App Engine
This is Rietveld 408576698