MD Settings: Make all HTML import href's relative.

MD Settings: Make all HTML import href's relative.

This allows those URLs to be treated the same way (as relative URLs) on
Windows/Linux by vulcanize, and also requires less --redirect flags passed
to Vulcanize.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2664503004
Cr-Commit-Position: refs/heads/master@{#447441}
Committed: https://chromium.googlesource.com/chromium/src/+/e4d460e023ab5c5880ba77dc812496c48a276148

[dpapad, 2017-01-27 23:12:27]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-01-27 23:13:13]

Description was changed from

==========
MD Settings: Make all HTML import href's relative.

This allows those URLs to be treated the same way (as relative URLs) on
Windows/Linux by vulcanize.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Make all HTML import href's relative.

This allows those URLs to be treated the same way (as relative URLs) on
Windows/Linux by vulcanize, and also requires less --redirect flags passed
to Vulcanize.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2017-01-27 23:13:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 23:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 23:17:40]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[dpapad, 2017-01-28 01:43:14]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 01:43:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-01-31 02:41:00]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2017-01-31 03:10:16]

lgtm with annoying global nit that does not need to be addressed now

https://codereview.chromium.org/2664503004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/2664503004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:20: <link
rel="import" href="appearance_fonts_page.html">
nit: alpha

[dpapad, 2017-01-31 18:29:24]

https://codereview.chromium.org/2664503004/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/appearance_page/appearance_page.html
(right):

https://codereview.chromium.org/2664503004/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/appearance_page/appearance_page.html:20: <link
rel="import" href="appearance_fonts_page.html">
On 2017/01/31 at 03:10:16, Dan Beam wrote:
> nit: alpha

Will address in a different CL. Leaning towards writing a script that processes
all our HTML imports automatically by

1) Always place chrome://resources/html/polymer.html at the top line.
2) Alphabetize remaining lines.
3) Perhaps we could also add a presubmit for this, if we think alhpa order is so
important.
WDYT?

[Dan Beam, 2017-01-31 18:46:10]

On 2017/01/31 18:29:24, dpapad wrote:
>
https://codereview.chromium.org/2664503004/diff/40001/chrome/browser/resource...
> File chrome/browser/resources/settings/appearance_page/appearance_page.html
> (right):
> 
>
https://codereview.chromium.org/2664503004/diff/40001/chrome/browser/resource...
> chrome/browser/resources/settings/appearance_page/appearance_page.html:20:
<link
> rel="import" href="appearance_fonts_page.html">
> On 2017/01/31 at 03:10:16, Dan Beam wrote:
> > nit: alpha
> 
> Will address in a different CL. Leaning towards writing a script that
processes
> all our HTML imports automatically by
> 
> 1) Always place chrome://resources/html/polymer.html at the top line.
> 2) Alphabetize remaining lines.
> 3) Perhaps we could also add a presubmit for this, if we think alhpa order is
so
> important.
> WDYT?

this seems fine to me, but polymer.html shouldn't actually be needed at the top
fwiw

[dpapad, 2017-01-31 18:48:48]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-01-31 18:49:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 19:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 19:36:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-01-31 20:36:51]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 20:37:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-01-31 22:27:01]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 23:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 23:57:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dpapad, 2017-02-01 02:03:23]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-02-01 02:03:23]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2664503004/#ps140001
(title: "resolve more conflicts")

[commit-bot: I haz the power, 2017-02-01 02:04:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 03:51:05]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1485914603197900,
"parent_rev": "58bc882e11a2ef3d8f446dff391b953bc08809bf", "commit_rev":
"e4d460e023ab5c5880ba77dc812496c48a276148"}

[commit-bot: I haz the power, 2017-02-01 03:52:02]

Description was changed from

==========
MD Settings: Make all HTML import href's relative.

This allows those URLs to be treated the same way (as relative URLs) on
Windows/Linux by vulcanize, and also requires less --redirect flags passed
to Vulcanize.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Make all HTML import href's relative.

This allows those URLs to be treated the same way (as relative URLs) on
Windows/Linux by vulcanize, and also requires less --redirect flags passed
to Vulcanize.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2664503004
Cr-Commit-Position: refs/heads/master@{#447441}
Committed:
https://chromium.googlesource.com/chromium/src/+/e4d460e023ab5c5880ba77dc8124...
==========

[commit-bot: I haz the power, 2017-02-01 03:52:07]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/e4d460e023ab5c5880ba77dc8124...