Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2661223003: MD Settings: Add a <base> tag in settings.html. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Add a <base> tag in settings.html. This is in preparation of converting all HTML improrts to relative URLs. BUG=673825 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2661223003 Cr-Commit-Position: refs/heads/master@{#447405} Committed: https://chromium.googlesource.com/chromium/src/+/fc7354b06f0318afbec6958b5514ae131352619d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/resources/settings/settings.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dpapad
3 years, 10 months ago (2017-01-31 22:59:10 UTC) #5
Dan Beam
lgtm
3 years, 10 months ago (2017-01-31 23:35:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2661223003/1
3 years, 10 months ago (2017-02-01 01:36:53 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 01:46:39 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc7354b06f0318afbec6958b5514...

Powered by Google App Engine
This is Rietveld 408576698