Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2664493005: Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors. (Closed)

Created:
3 years, 10 months ago by Jacob
Modified:
3 years, 10 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/959a375541825cb4318fd6599e476b47a2e4d0d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -44 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 3 chunks +27 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 3 chunks +27 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 3 chunks +27 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 3 chunks +27 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View Binary file 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart View 1 chunk +32 lines, -10 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
Identical CL applying to the main branch.
3 years, 10 months ago (2017-01-27 18:51:27 UTC) #2
vsm
lgtm
3 years, 10 months ago (2017-01-27 18:57:29 UTC) #3
Jacob
3 years, 10 months ago (2017-01-27 22:23:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
959a375541825cb4318fd6599e476b47a2e4d0d7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698