Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors.

pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// This library defines runtime operations on objects used by the code
 /// generator.
 part of dart._runtime;
 
 class InvocationImpl extends Invocation {
   final Symbol memberName;
@@ skipping 28 matching lines @@
   if (f != null) {
     var type = getType(obj);
 
     if (hasField(type, f) || hasGetter(type, f)) return JS('', '#[#]', obj, f);
     if (hasMethod(type, f)) return bind(obj, f, JS('', 'void 0'));
   }
   return noSuchMethod(
       obj, new InvocationImpl(field, JS('', '[]'), isGetter: true));
 }
 
+_stripGenericArguments(type) {
+  var genericClass = getGenericClass(type);
+  if (genericClass != null) return JS('', '#()', genericClass);
+  return type;
+}
+
+// Version of dput that matches legacy Dart 1 type check rules.
+// TODO(jacobr): remove this temporary workaround when mirrors based
+// PageLoader code can generate the correct reified generic types.
+dputLegacy(obj, field, value) {
+  var f = _canonicalMember(obj, field);
+  _trackCall(obj);
+  if (f != null) {
+    var objType = getType(obj);
+    var setterType = getSetterType(objType, f);
+    if (JS('bool', '# != void 0', setterType)) {
+      return JS('', '#[#] = #', obj, f, check(value,  _stripGenericArguments(JS('', '#.args[0]', setterType))));
+    } else {
+      var fieldType = getFieldType(objType, f);
+      // TODO(jacobr): add metadata tracking which fields are final and throw
+      // if a setter is called on a final field.
+      if (JS('bool', '# != void 0', fieldType)) {
+        return JS('', '#[#] = #', obj, f, check(value, _stripGenericArguments(fieldType)));
+      }
+    }
+  }
+  return noSuchMethod(
+      obj, new InvocationImpl(field, JS('', '[#]', value), isSetter: true));
+}
+
 dput(obj, field, value) {
   var f = _canonicalMember(obj, field);
   _trackCall(obj);
   if (f != null) {
     var objType = getType(obj);
     var setterType = getSetterType(objType, f);
     if (JS('bool', '# != void 0', setterType)) {
-      // TODO(jacobr): throw a type error instead of a NoSuchMethodError if
-      // the type of the setter doesn't match.
-      if (instanceOfOrNull(value, JS('', '#.args[0]', setterType))) {
-        return JS('', '#[#] = #', obj, f, value);
-      }
+      return JS('', '#[#] = #', obj, f, check(value,  JS('', '#.args[0]', setterType)));
     } else {
       var fieldType = getFieldType(objType, f);
       // TODO(jacobr): add metadata tracking which fields are final and throw
       // if a setter is called on a final field.
       if (JS('bool', '# != void 0', fieldType)) {
-        // TODO(jacobr): throw a type error instead of a NoSuchMethodError if
-        // the type of the field doesn't match.
-        if (instanceOfOrNull(value, fieldType)) {
-          return JS('', '#[#] = #', obj, f, value);
-        }
+        return JS('', '#[#] = #', obj, f, check(value, fieldType));
       }
     }
   }
   return noSuchMethod(
       obj, new InvocationImpl(field, JS('', '[#]', value), isSetter: true));
 }
 
 /// Check that a function of a given type can be applied to
 /// actuals.
 _checkApply(type, actuals) => JS(
@@ skipping 821 matching lines @@
     name = '+' + name;
   }
   return name;
 }
 
 /// Emulates the implicit "loadLibrary" function provided by a deferred library.
 ///
 /// Libraries are not actually deferred in DDC, so this just returns a future
 /// that completes immediately.
 Future loadLibrary() => new Future.value();