Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: pkg/dev_compiler/tool/input_sdk/private/js_mirrors.dart

Issue 2664493005: Fix getFieldType to handle metadata and workaround bad types for setters called via mirrors. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart._js_mirrors; 5 library dart._js_mirrors;
6 6
7 import 'dart:mirrors'; 7 import 'dart:mirrors';
8 import 'dart:_foreign_helper' show JS; 8 import 'dart:_foreign_helper' show JS;
9 import 'dart:_internal' as _internal; 9 import 'dart:_internal' as _internal;
10 10
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 return mirror; 42 return mirror;
43 } 43 }
44 44
45 final dynamic _dart = JS('', 'dart'); 45 final dynamic _dart = JS('', 'dart');
46 46
47 dynamic _dload(obj, String name) { 47 dynamic _dload(obj, String name) {
48 return JS('', '#.dload(#, #)', _dart, obj, name); 48 return JS('', '#.dload(#, #)', _dart, obj, name);
49 } 49 }
50 50
51 void _dput(obj, String name, val) { 51 void _dput(obj, String name, val) {
52 JS('', '#.dput(#, #, #)', _dart, obj, name, val); 52 JS('', '#.dputLegacy(#, #, #)', _dart, obj, name, val);
53 } 53 }
54 54
55 dynamic _dcall(obj, List args) { 55 dynamic _dcall(obj, List args) {
56 return JS('', '#.dcall(#, ...#)', _dart, obj, args); 56 return JS('', '#.dcall(#, ...#)', _dart, obj, args);
57 } 57 }
58 58
59 dynamic _dsend(obj, String name, List args) { 59 dynamic _dsend(obj, String name, List args) {
60 return JS('', '#.dsend(#, #, ...#)', _dart, obj, name, args); 60 return JS('', '#.dsend(#, #, ...#)', _dart, obj, name, args);
61 } 61 }
62 62
(...skipping 586 matching lines...) Expand 10 before | Expand all | Expand 10 after
649 var param = 649 var param =
650 new JsParameterMirror._(new Symbol(''), _wrap(type), metadata); 650 new JsParameterMirror._(new Symbol(''), _wrap(type), metadata);
651 params[i + args.length] = param; 651 params[i + args.length] = param;
652 } 652 }
653 653
654 _params = new List.unmodifiable(params); 654 _params = new List.unmodifiable(params);
655 } 655 }
656 656
657 String toString() => "MethodMirror on '$_name'"; 657 String toString() => "MethodMirror on '$_name'";
658 } 658 }
OLDNEW
« no previous file with comments | « pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/operations.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698