Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2664403003: [LayoutNG] Stack allocate NGLayoutOpportunityIterator. (Closed)

Created:
3 years, 10 months ago by ikilpatrick
Modified:
3 years, 10 months ago
Reviewers:
Gleb Lanbin
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Stack allocate NGLayoutOpportunityIterator. BUG=635619 Review-Url: https://codereview.chromium.org/2664403003 Cr-Commit-Position: refs/heads/master@{#447722} Committed: https://chromium.googlesource.com/chromium/src/+/76de065c8a9efc8b7d9cf28c38c757c4bec47392

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -58 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 6 chunks +38 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h View 3 chunks +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 19 (11 generated)
ikilpatrick
3 years, 10 months ago (2017-02-01 10:58:52 UTC) #6
Gleb Lanbin
lgtm
3 years, 10 months ago (2017-02-01 17:46:28 UTC) #7
Gleb Lanbin
looks like we already made the decision about migrating out of Oilpan. Can we send ...
3 years, 10 months ago (2017-02-01 19:42:39 UTC) #8
ikilpatrick
yeah discussion at blinkon, will send an email to layout-dev@chromium.
3 years, 10 months ago (2017-02-02 01:54:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664403003/20001
3 years, 10 months ago (2017-02-02 01:54:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/382376)
3 years, 10 months ago (2017-02-02 06:18:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664403003/20001
3 years, 10 months ago (2017-02-02 06:40:34 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 08:02:34 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/76de065c8a9efc8b7d9cf28c38c7...

Powered by Google App Engine
This is Rietveld 408576698