[LayoutNG] Stack allocate NGLayoutOpportunityIterator.

third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_constraint_space.h"
 
 #include "core/layout/ng/ng_constraint_space.h"
 #include "core/layout/ng/ng_constraint_space_builder.h"
 #include "core/layout/ng/ng_layout_opportunity_iterator.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 18 matching lines @@
 static String OpportunityToString(const NGLayoutOpportunity& opportunity) {
   return opportunity.IsEmpty() ? String("(empty)") : opportunity.ToString();
 }
 
 TEST(NGConstraintSpaceTest, LayoutOpportunitiesNoExclusions) {
   NGLogicalSize size;
   size.inline_size = LayoutUnit(600);
   size.block_size = LayoutUnit(400);
   auto* space =
       ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::kLtr, size);
-  auto* iterator = space->LayoutOpportunities();
-  EXPECT_EQ("0,0 600x400", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
+
+  NGLayoutOpportunityIterator iterator(space);
+  EXPECT_EQ("0,0 600x400", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("(empty)", OpportunityToString(iterator.Next()));
 }
 
 TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopRightExclusion) {
   NGLogicalSize size;
   size.inline_size = LayoutUnit(600);
   size.block_size = LayoutUnit(400);
   // Create a space with a 100x100 exclusion in the top right corner.
   auto* space =
       ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::kLtr, size);
   NGExclusion exclusion;
   exclusion.rect.size = {/* inline_size */ LayoutUnit(100),
                          /* block_size */ LayoutUnit(100)};
   exclusion.rect.offset = {/* inline_offset */ LayoutUnit(500),
                            /* block_offset */ LayoutUnit(0)};
   space->AddExclusion(exclusion);
-  auto* iterator = space->LayoutOpportunities();
+
+  NGLayoutOpportunityIterator iterator(space);
   // First opportunity should be to the left of the exclusion.
-  EXPECT_EQ("0,0 500x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,0 500x400", OpportunityToString(iterator.Next()));
   // Second opportunity should be below the exclusion.
-  EXPECT_EQ("0,100 600x300", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,100 600x300", OpportunityToString(iterator.Next()));
   // There should be no third opportunity.
-  EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("(empty)", OpportunityToString(iterator.Next()));
 }
 
 TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopLeftExclusion) {
   NGLogicalSize size;
   size.inline_size = LayoutUnit(600);
   size.block_size = LayoutUnit(400);
   // Create a space with a 100x100 exclusion in the top left corner.
   auto* space =
       ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::kLtr, size);
   NGExclusion exclusion;
   exclusion.rect.size = {/* inline_size */ LayoutUnit(100),
                          /* block_size */ LayoutUnit(100)};
   exclusion.rect.offset = {/* inline_offset */ LayoutUnit(0),
                            /* block_offset */ LayoutUnit(0)};
   space->AddExclusion(exclusion);
-  auto* iterator = space->LayoutOpportunities();
+
+  NGLayoutOpportunityIterator iterator(space);
   // First opportunity should be to the right of the exclusion.
-  EXPECT_EQ("100,0 500x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("100,0 500x400", OpportunityToString(iterator.Next()));
   // Second opportunity should be below the exclusion.
-  EXPECT_EQ("0,100 600x300", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,100 600x300", OpportunityToString(iterator.Next()));
   // There should be no third opportunity.
-  EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("(empty)", OpportunityToString(iterator.Next()));
 }
 
 // Verifies that Layout Opportunity iterator produces 7 layout opportunities
 // from 4 start points created by 2 CSS exclusions positioned in the middle of
 // the main constraint space.
 //
 // Test case visual representation:
 //
 //         100  200   300  400  500
 //     (1)--|----|-(2)-|----|----|-(3)-+
@@ skipping 24 matching lines @@
                           /* block_size */ LayoutUnit(100)};
   exclusion1.rect.offset = {/* inline_offset */ LayoutUnit(150),
                             /* block_offset */ LayoutUnit(200)};
   space->AddExclusion(exclusion1);
   NGExclusion exclusion2;
   exclusion2.rect.size = {/* inline_size */ LayoutUnit(50),
                           /* block_size */ LayoutUnit(50)};
   exclusion2.rect.offset = {/* inline_offset */ LayoutUnit(500),
                             /* block_offset */ LayoutUnit(350)};
   space->AddExclusion(exclusion2);
-  auto* iterator = space->LayoutOpportunities();
+
+  NGLayoutOpportunityIterator iterator(space);
   // 1st Start point
-  EXPECT_EQ("0,0 600x200", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("0,0 150x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,0 600x200", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("0,0 150x400", OpportunityToString(iterator.Next()));
   // 2nd Start point
-  EXPECT_EQ("250,0 350x350", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("250,0 250x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("250,0 350x350", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("250,0 250x400", OpportunityToString(iterator.Next()));
   // 3rd Start point
-  EXPECT_EQ("550,0 50x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("550,0 50x400", OpportunityToString(iterator.Next()));
   // 4th Start point
-  EXPECT_EQ("0,300 600x50", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("0,300 500x100", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,300 600x50", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("0,300 500x100", OpportunityToString(iterator.Next()));
   // Iterator is exhausted.
-  EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("(empty)", OpportunityToString(iterator.Next()));
 }
 
 // This test is the same as LayoutOpportunitiesTwoInMiddle with the only
 // difference that NGLayoutOpportunityIterator takes 2 additional arguments:
 // - origin_point that changes the iterator to return Layout Opportunities that
 // lay after the origin point.
 // - leader_point that together with origin_point creates a temporary exclusion
 //
 // Expected:
 //   Layout opportunity iterator generates the next opportunities:
@@ skipping 15 matching lines @@
                           /* block_size */ LayoutUnit(100)};
   exclusion1.rect.offset = {/* inline_offset */ LayoutUnit(150),
                             /* block_offset */ LayoutUnit(200)};
   space->AddExclusion(exclusion1);
   NGExclusion exclusion2;
   exclusion2.rect.size = {/* inline_size */ LayoutUnit(50),
                           /* block_size */ LayoutUnit(50)};
   exclusion2.rect.offset = {/* inline_offset */ LayoutUnit(500),
                             /* block_offset */ LayoutUnit(350)};
   space->AddExclusion(exclusion2);
+
   const NGLogicalOffset origin_point = {LayoutUnit(0), LayoutUnit(200)};
   const NGLogicalOffset leader_point = {LayoutUnit(250), LayoutUnit(300)};
-  auto* iterator =
-      new NGLayoutOpportunityIterator(space, origin_point, leader_point);
+  NGLayoutOpportunityIterator iterator(space, origin_point, leader_point);
   // 1st Start Point
-  EXPECT_EQ("250,200 350x150", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("250,200 250x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("250,200 350x150", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("250,200 250x400", OpportunityToString(iterator.Next()));
   // 2nd Start Point
-  EXPECT_EQ("550,200 50x400", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("550,200 50x400", OpportunityToString(iterator.Next()));
   // 3rd Start Point
-  EXPECT_EQ("0,300 600x50", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("0,300 500x300", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,300 600x50", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("0,300 500x300", OpportunityToString(iterator.Next()));
   // 4th Start Point
-  EXPECT_EQ("0,400 600x200", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("0,400 600x200", OpportunityToString(iterator.Next()));
   // TODO(glebl): The opportunity below should not be generated.
-  EXPECT_EQ("250,400 350x200", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("250,400 350x200", OpportunityToString(iterator.Next()));
   // Iterator is exhausted.
-  EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
+  EXPECT_EQ("(empty)", OpportunityToString(iterator.Next()));
 }
 // Verifies that Layout Opportunity iterator ignores the exclusion that is not
 // within constraint space.
 //
 // Test case visual representation:
 //
 //         100  200  300  400  500
 //     +----|----|----|----|----|----+
 //  50 |                             |
 // 100 |                             |
 //     +-----------------------------+
 //      ***  <- Exclusion
 //
 // Expected:
 //   Layout opportunity iterator generates only one opportunity that equals to
 //   available constraint space, i.e. 0,0 600x200
 TEST(NGConstraintSpaceTest, LayoutOpportunitiesWithOutOfBoundsExclusions) {
   NGLogicalSize size;
   size.inline_size = LayoutUnit(600);
   size.block_size = LayoutUnit(100);
   auto* space =
       ConstructConstraintSpace(kHorizontalTopBottom, TextDirection::kLtr, size);
   NGExclusion exclusion;
   exclusion.rect.size = {/* inline_size */ LayoutUnit(100),
                          /* block_size */ LayoutUnit(100)};
   exclusion.rect.offset = {/* inline_offset */ LayoutUnit(0),
                            /* block_offset */ LayoutUnit(150)};
   space->AddExclusion(exclusion);
-  auto* iterator = space->LayoutOpportunities();
-  EXPECT_EQ("0,0 600x100", OpportunityToString(iterator->Next()));
-  EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
+
+  NGLayoutOpportunityIterator iterator(space);
+  EXPECT_EQ("0,0 600x100", OpportunityToString(iterator.Next()));
+  EXPECT_EQ("(empty)", OpportunityToString(iterator.Next()));
 }
 
 }  // namespace
 }  // namespace blink