Clears out external protocol data when cookies and site data is cleared.

chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

Index: chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
index e8474db05fcc253855bbe04c2b52b9c134769905..ee9581126e128e160e7025533e1f622bf4fb21fe 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_api.cc
@@ -51,6 +51,7 @@ const char kPluginDataKey[] = "pluginData";
 const char kServiceWorkersKey[] = "serviceWorkers";
 const char kCacheStorageKey[] = "cacheStorage";
 const char kWebSQLKey[] = "webSQL";
+const char kExternalProtocolDataKey[] = "externalProtocolData";

[msramek, 2017/02/15 20:36:52]

Note that it is not a requirement from privacy side to wire every new datatype
to the extension `browsingData` API.

If you only did so because this test suite (browsing_data_test.cc) was failing,
you can use the workaround from this CL instead:
https://codereview.chromium.org/2354843006/

[ramyasharma, 2017/02/16 03:29:47]

Thank you. This worked, and I reverted the changes to the extension api.

 
 // Option keys.
 const char kExtensionsKey[] = "extension";
@@ -103,6 +104,10 @@ int MaskForKey(const char* key) {
     return BrowsingDataRemover::REMOVE_CACHE_STORAGE;
   if (strcmp(key, extension_browsing_data_api_constants::kWebSQLKey) == 0)
     return BrowsingDataRemover::REMOVE_WEBSQL;
+  if (strcmp(key,
+             extension_browsing_data_api_constants::kExternalProtocolDataKey) ==
+      0)
+    return BrowsingDataRemover::REMOVE_EXTERNAL_PROTOCOL_DATA;
 
   return 0;
 }
@@ -182,8 +187,11 @@ ExtensionFunction::ResponseAction BrowsingDataSettingsFunction::Run() {
              extension_browsing_data_api_constants::kWebSQLKey,
              delete_site_data);
   SetDetails(selected.get(), permitted.get(),
-      extension_browsing_data_api_constants::kChannelIDsKey,
-      delete_site_data);
+             extension_browsing_data_api_constants::kExternalProtocolDataKey,
+             delete_site_data);
+  SetDetails(selected.get(), permitted.get(),
+             extension_browsing_data_api_constants::kChannelIDsKey,
+             delete_site_data);
   SetDetails(selected.get(), permitted.get(),
              extension_browsing_data_api_constants::kServiceWorkersKey,
              delete_site_data);
@@ -468,3 +476,9 @@ bool BrowsingDataRemoveWebSQLFunction::GetRemovalMask(int* removal_mask) {
   *removal_mask = BrowsingDataRemover::REMOVE_WEBSQL;
   return true;
 }
+
+bool BrowsingDataRemoveExternalProtocolDataFunction::GetRemovalMask(
+    int* removal_mask) {
+  *removal_mask = BrowsingDataRemover::REMOVE_EXTERNAL_PROTOCOL_DATA;
+  return true;
+}