Clears out external protocol data when cookies and site data is cleared.

chrome/browser/extensions/api/browsing_data/browsing_data_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines the Chrome Extensions BrowsingData API functions, which entail
 // clearing browsing data, and clearing the browser's cache (which, let's be
 // honest, are the same thing), as specified in the extension API JSON.
 
 #include "chrome/browser/extensions/api/browsing_data/browsing_data_api.h"
 
@@ skipping 33 matching lines @@
 const char kFileSystemsKey[] = "fileSystems";
 const char kFormDataKey[] = "formData";
 const char kHistoryKey[] = "history";
 const char kIndexedDBKey[] = "indexedDB";
 const char kLocalStorageKey[] = "localStorage";
 const char kPasswordsKey[] = "passwords";
 const char kPluginDataKey[] = "pluginData";
 const char kServiceWorkersKey[] = "serviceWorkers";
 const char kCacheStorageKey[] = "cacheStorage";
 const char kWebSQLKey[] = "webSQL";
+const char kExternalProtocolDataKey[] = "externalProtocolData";

[msramek, 2017/02/15 20:36:52]

Note that it is not a requirement from privacy side to wire every new datatype
to the extension `browsingData` API.

If you only did so because this test suite (browsing_data_test.cc) was failing,
you can use the workaround from this CL instead:
https://codereview.chromium.org/2354843006/

[ramyasharma, 2017/02/16 03:29:47]

Thank you. This worked, and I reverted the changes to the extension api.

 
 // Option keys.
 const char kExtensionsKey[] = "extension";
 const char kOriginTypesKey[] = "originTypes";
 const char kProtectedWebKey[] = "protectedWeb";
 const char kSinceKey[] = "since";
 const char kUnprotectedWebKey[] = "unprotectedWeb";
 
 // Errors!
 // The placeholder will be filled by the name of the affected data type (e.g.,
@@ skipping 32 matching lines @@
     return BrowsingDataRemover::REMOVE_PASSWORDS;
   if (strcmp(key, extension_browsing_data_api_constants::kPluginDataKey) == 0)
     return BrowsingDataRemover::REMOVE_PLUGIN_DATA;
   if (strcmp(key, extension_browsing_data_api_constants::kServiceWorkersKey) ==
       0)
     return BrowsingDataRemover::REMOVE_SERVICE_WORKERS;
   if (strcmp(key, extension_browsing_data_api_constants::kCacheStorageKey) == 0)
     return BrowsingDataRemover::REMOVE_CACHE_STORAGE;
   if (strcmp(key, extension_browsing_data_api_constants::kWebSQLKey) == 0)
     return BrowsingDataRemover::REMOVE_WEBSQL;
+  if (strcmp(key,
+             extension_browsing_data_api_constants::kExternalProtocolDataKey) ==
+      0)
+    return BrowsingDataRemover::REMOVE_EXTERNAL_PROTOCOL_DATA;
 
   return 0;
 }
 
 // Returns false if any of the selected data types are not allowed to be
 // deleted.
 bool IsRemovalPermitted(int removal_mask, PrefService* prefs) {
   // Enterprise policy or user preference might prohibit deleting browser or
   // download history.
   if ((removal_mask & BrowsingDataRemover::REMOVE_HISTORY) ||
@@ skipping 59 matching lines @@
   SetDetails(selected.get(), permitted.get(),
              extension_browsing_data_api_constants::kIndexedDBKey,
              delete_site_data);
   SetDetails(selected.get(), permitted.get(),
       extension_browsing_data_api_constants::kLocalStorageKey,
       delete_site_data);
   SetDetails(selected.get(), permitted.get(),
              extension_browsing_data_api_constants::kWebSQLKey,
              delete_site_data);
   SetDetails(selected.get(), permitted.get(),
-      extension_browsing_data_api_constants::kChannelIDsKey,
-      delete_site_data);
+             extension_browsing_data_api_constants::kExternalProtocolDataKey,
+             delete_site_data);
+  SetDetails(selected.get(), permitted.get(),
+             extension_browsing_data_api_constants::kChannelIDsKey,
+             delete_site_data);
   SetDetails(selected.get(), permitted.get(),
              extension_browsing_data_api_constants::kServiceWorkersKey,
              delete_site_data);
   SetDetails(selected.get(), permitted.get(),
              extension_browsing_data_api_constants::kCacheStorageKey,
              delete_site_data);
 
   SetDetails(selected.get(), permitted.get(),
              extension_browsing_data_api_constants::kPluginDataKey,
              delete_site_data &&
@@ skipping 264 matching lines @@
 
 bool BrowsingDataRemoveCacheStorageFunction::GetRemovalMask(int* removal_mask) {
   *removal_mask = BrowsingDataRemover::REMOVE_CACHE_STORAGE;
   return true;
 }
 
 bool BrowsingDataRemoveWebSQLFunction::GetRemovalMask(int* removal_mask) {
   *removal_mask = BrowsingDataRemover::REMOVE_WEBSQL;
   return true;
 }
+
+bool BrowsingDataRemoveExternalProtocolDataFunction::GetRemovalMask(
+    int* removal_mask) {
+  *removal_mask = BrowsingDataRemover::REMOVE_EXTERNAL_PROTOCOL_DATA;
+  return true;
+}