Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(909)

Unified Diff: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc

Issue 2664253006: Clears out external protocol data when cookies and site data is cleared. (Closed)
Patch Set: a Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
diff --git a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
index 7cbdbbb51e4c6622129ee93575b62772a8e2bebc..b2098cc0eb27dfd7b7a3555987af0bfff0a98448 100644
--- a/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
+++ b/chrome/browser/extensions/api/browsing_data/browsing_data_test.cc
@@ -41,7 +41,7 @@ const char kRemoveEverythingArguments[] =
"\"history\": true, \"indexedDB\": true, \"localStorage\": true, "
"\"serverBoundCertificates\": true, \"passwords\": true, "
"\"pluginData\": true, \"serviceWorkers\": true, \"cacheStorage\": true, "
- "\"webSQL\": true"
+ "\"webSQL\": true, \"externalProtocolData\": true"
"}]";
class ExtensionBrowsingDataTest : public InProcessBrowserTest {
@@ -221,7 +221,10 @@ class ExtensionBrowsingDataTest : public InProcessBrowserTest {
GetAsMask(data_to_remove, "webSQL",
BrowsingDataRemover::REMOVE_WEBSQL) |
GetAsMask(data_to_remove, "serverBoundCertificates",
- BrowsingDataRemover::REMOVE_CHANNEL_IDS);
+ BrowsingDataRemover::REMOVE_CHANNEL_IDS) |
+ GetAsMask(data_to_remove, "externalProtocolData",
+ BrowsingDataRemover::REMOVE_EXTERNAL_PROTOCOL_DATA);
+
EXPECT_EQ(expected_removal_mask, removal_mask);
}
@@ -268,6 +271,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest, RemovalProhibited) {
CheckRemovalPermitted("{\"serviceWorkers\": true}", true);
CheckRemovalPermitted("{\"cacheStorage\": true}", true);
CheckRemovalPermitted("{\"webSQL\": true}", true);
+ CheckRemovalPermitted("{\"externalProtocolData\": true}", true);
// The entire removal is prohibited if any part is.
CheckRemovalPermitted("{\"cache\": true, \"history\": true}", false);
@@ -363,6 +367,9 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowsingDataTest,
"cacheStorage", BrowsingDataRemover::REMOVE_CACHE_STORAGE);
RunBrowsingDataRemoveWithKeyAndCompareRemovalMask(
"webSQL", BrowsingDataRemover::REMOVE_WEBSQL);
+ RunBrowsingDataRemoveWithKeyAndCompareRemovalMask(
+ "externalProtocolData",
+ BrowsingDataRemover::REMOVE_EXTERNAL_PROTOCOL_DATA);
}
// Test an arbitrary combination of data types.

Powered by Google App Engine
This is Rietveld 408576698