Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2664233003: DevTools: Add more Mac shortcuts into CodeMirrorTextEditor (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

DevTools: Add more Mac shortcuts into CodeMirrorTextEditor MacOS has a lot of Emacs-style keyboard shortcuts that we lost when moving the console from contenteditable to CodeMirror. BUG=671269 Review-Url: https://codereview.chromium.org/2559603002 Cr-Commit-Position: refs/heads/master@{#437457} (cherry picked from commit 247b2e4c45b9e2504c54a0725f39df52d8c071b2) Review-Url: https://codereview.chromium.org/2664233003 . Cr-Commit-Position: refs/branch-heads/2924@{#893} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/edfa3ce871a7748b1e7b8162f9ceb409a613b965

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
lushnikov
3 years, 10 months ago (2017-02-01 02:14:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edfa3ce871a7748b1e7b8162f9ceb409a613b965.

Powered by Google App Engine
This is Rietveld 408576698