Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2559603002:
DevTools: Add more Mac shortcuts into CodeMirrorTextEditor (Closed)
|
Created:
4 years ago by einbinder Modified:
4 years ago Reviewers:
lushnikov CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDevTools: Add more Mac shortcuts into CodeMirrorTextEditor
MacOS has a lot of Emacs-style keyboard shortcuts that we lost when
moving the console from contenteditable to CodeMirror.
BUG=671269
Committed: https://crrev.com/247b2e4c45b9e2504c54a0725f39df52d8c071b2
Cr-Commit-Position: refs/heads/master@{#437457}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (8 generated)
einbinder@chromium.org changed reviewers: + lushnikov@chromium.org
ptal
https://codereview.chromium.org/2559603002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/2559603002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js:115: 'Ctrl-B': 'goCharLeft', shall we add these in the ConsolePrompt only?
https://codereview.chromium.org/2559603002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js (right): https://codereview.chromium.org/2559603002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js:115: 'Ctrl-B': 'goCharLeft', On 2016/12/07 at 01:04:53, lushnikov wrote: > shall we add these in the ConsolePrompt only? Why? They occur in <textarea> on mac, so it makes sense for them to exist in sources. They are also default in CodeMirror, but we override the Mac keymap.
lgtm
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by einbinder@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481244090392440, "parent_rev":
"a473c719931cf552e8345de3db48209b4d976de9", "commit_rev":
"939918f23aedbf399da78566279429be0c3fd0a2"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== DevTools: Add more Mac shortcuts into CodeMirrorTextEditor MacOS has a lot of Emacs-style keyboard shortcuts that we lost when moving the console from contenteditable to CodeMirror. BUG=671269 ========== to ========== DevTools: Add more Mac shortcuts into CodeMirrorTextEditor MacOS has a lot of Emacs-style keyboard shortcuts that we lost when moving the console from contenteditable to CodeMirror. BUG=671269 Committed: https://crrev.com/247b2e4c45b9e2504c54a0725f39df52d8c071b2 Cr-Commit-Position: refs/heads/master@{#437457} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/247b2e4c45b9e2504c54a0725f39df52d8c071b2 Cr-Commit-Position: refs/heads/master@{#437457} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
