Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2664043002: Revert of [WPR] Implement platform dependent recordings for WPR archives. (Closed)

Created:
3 years, 10 months ago by rnephew (Reviews Here)
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [WPR] Implement platform dependent recordings for WPR archives. (patchset #17 id:360001 of https://codereview.chromium.org/2626373004/ ) Reason for revert: Chromium side tests are failing, and this shouldn't impact them. Reverting to figure out why. Original issue's description: > [WPR] Implement platform dependent recordings for WPR archives. > > BUG=chromium:618698 ,catapult:#2814 > > Review-Url: https://codereview.chromium.org/2626373004 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7af1a1e70eb99a3162fc2a1d82d209468a887a60 TBR=charliea@chromium.org,nednguyen@google.com,perezju@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:618698 ,catapult:#2814 Review-Url: https://codereview.chromium.org/2664043002 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/986b4e8b58804b7aa7bec4479b10087607ba9548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -663 lines) Patch
M telemetry/telemetry/internal/story_runner.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/page/__init__.py View 1 chunk +2 lines, -3 lines 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +1 line, -1 line 0 comments Download
M telemetry/telemetry/story/story.py View 2 chunks +1 line, -4 lines 0 comments Download
M telemetry/telemetry/story/story_set.py View 2 chunks +2 lines, -3 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info.py View 3 chunks +1 line, -7 lines 0 comments Download
D telemetry/telemetry/wpr/archive_info2.py View 1 chunk +0 lines, -215 lines 0 comments Download
D telemetry/telemetry/wpr/archive_info2_unittest.py View 1 chunk +0 lines, -406 lines 0 comments Download
M telemetry/telemetry/wpr/archive_info_unittest.py View 2 chunks +0 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
rnephew (Reviews Here)
Created Revert of [WPR] Implement platform dependent recordings for WPR archives.
3 years, 10 months ago (2017-01-31 00:19:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664043002/1
3 years, 10 months ago (2017-01-31 00:20:08 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:20:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698