Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Side by Side Diff: telemetry/telemetry/story/story.py

Issue 2664043002: Revert of [WPR] Implement platform dependent recordings for WPR archives. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « telemetry/telemetry/page/shared_page_state.py ('k') | telemetry/telemetry/story/story_set.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from telemetry.story import shared_state as shared_state_module 7 from telemetry.story import shared_state as shared_state_module
8 8
9 _next_story_id = 0 9 _next_story_id = 0
10 10
(...skipping 12 matching lines...) Expand all
23 in results output. 23 in results output.
24 tags: A list or set of string labels that are used for filtering. See 24 tags: A list or set of string labels that are used for filtering. See
25 story.story_filter for more information. 25 story.story_filter for more information.
26 is_local: If True, the story does not require network. 26 is_local: If True, the story does not require network.
27 grouping_keys: A dict of grouping keys that will be added to values computed 27 grouping_keys: A dict of grouping keys that will be added to values computed
28 on this story. 28 on this story.
29 """ 29 """
30 30
31 def __init__(self, shared_state_class, name='', tags=None, 31 def __init__(self, shared_state_class, name='', tags=None,
32 is_local=False, make_javascript_deterministic=True, 32 is_local=False, make_javascript_deterministic=True,
33 grouping_keys=None, platform_specific=False): 33 grouping_keys=None):
34 """ 34 """
35 Args: 35 Args:
36 make_javascript_deterministic: Whether JavaScript performed on 36 make_javascript_deterministic: Whether JavaScript performed on
37 the page is made deterministic across multiple runs. This 37 the page is made deterministic across multiple runs. This
38 requires that the web content is served via Web Page Replay 38 requires that the web content is served via Web Page Replay
39 to take effect. This setting does not affect stories containing no web 39 to take effect. This setting does not affect stories containing no web
40 content or where the HTTP MIME type is not text/html.See also: 40 content or where the HTTP MIME type is not text/html.See also:
41 _InjectScripts method in third_party/web-page-replay/httpclient.py. 41 _InjectScripts method in third_party/web-page-replay/httpclient.py.
42 platform_specific: Boolean indicating if a separate web page replay
43 recording is required on each platform.
44 """ 42 """
45 assert issubclass(shared_state_class, 43 assert issubclass(shared_state_class,
46 shared_state_module.SharedState) 44 shared_state_module.SharedState)
47 self._shared_state_class = shared_state_class 45 self._shared_state_class = shared_state_class
48 self._name = name 46 self._name = name
49 self._platform_specific = platform_specific
50 global _next_story_id 47 global _next_story_id
51 self._id = _next_story_id 48 self._id = _next_story_id
52 _next_story_id += 1 49 _next_story_id += 1
53 if tags is None: 50 if tags is None:
54 tags = set() 51 tags = set()
55 elif isinstance(tags, list): 52 elif isinstance(tags, list):
56 tags = set(tags) 53 tags = set(tags)
57 else: 54 else:
58 assert isinstance(tags, set) 55 assert isinstance(tags, set)
59 self._tags = tags 56 self._tags = tags
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 def serving_dir(self): 126 def serving_dir(self):
130 """Returns the absolute path to a directory with hash files to data that 127 """Returns the absolute path to a directory with hash files to data that
131 should be updated from cloud storage, or None if no files need to be 128 should be updated from cloud storage, or None if no files need to be
132 updated. 129 updated.
133 """ 130 """
134 return None 131 return None
135 132
136 @property 133 @property
137 def make_javascript_deterministic(self): 134 def make_javascript_deterministic(self):
138 return self._make_javascript_deterministic 135 return self._make_javascript_deterministic
OLDNEW
« no previous file with comments | « telemetry/telemetry/page/shared_page_state.py ('k') | telemetry/telemetry/story/story_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698