Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2664033005: Revert of [tools] Fix RegExp for ticksprocessor. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [tools] Fix RegExp for ticksprocessor. (patchset #2 id:20001 of https://codereview.chromium.org/2668953002/ ) Reason for revert: AAAAAHHHHHHH Original issue's description: > [tools] Fix RegExp for ticksprocessor. > > Properly attribute all builtins, bytecode handlers and other stubs to > the calling function unless --separate-ic is passed. > > R=jarin@chromium.org > NOTRY=true > > Review-Url: https://codereview.chromium.org/2668953002 > Cr-Commit-Position: refs/heads/master@{#42849} > Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac074b85 TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2664033005 Cr-Commit-Position: refs/heads/master@{#42851} Committed: https://chromium.googlesource.com/v8/v8/+/2f78186ee9f77e268d342b960c565965d8dc4300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/tickprocessor.js View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Benedikt Meurer
Created Revert of [tools] Fix RegExp for ticksprocessor.
3 years, 10 months ago (2017-02-01 12:02:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664033005/1
3 years, 10 months ago (2017-02-01 12:02:17 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 12:02:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2f78186ee9f77e268d342b960c565965d8d...

Powered by Google App Engine
This is Rietveld 408576698