Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2668953002:
[tools] Fix RegExp for ticksprocessor. (Closed)
|
Created:
3 years, 10 months ago by Benedikt Meurer Modified:
3 years, 10 months ago Reviewers:
Jarin CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[tools] Fix RegExp for ticksprocessor.
Properly attribute all builtins, bytecode handlers and other stubs to
the calling function unless --separate-ic is passed.
R=jarin@chromium.org
Review-Url: https://codereview.chromium.org/2668953002
Cr-Original-Commit-Position: refs/heads/master@{#42849}
Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac074b85
Review-Url: https://codereview.chromium.org/2668953002
Cr-Commit-Position: refs/heads/master@{#42852}
Committed: https://chromium.googlesource.com/v8/v8/+/58611d0115ff4031e26aefaf7f571f4b3a26cf07
Patch Set 1 #Patch Set 2 : KeyedCallIC no longer exists. #Patch Set 3 : Cementation! #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
Description was changed from ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org ========== to ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org NOTRY=true ==========
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2668953002/#ps20001 (title: "KeyedCallIC no longer exists.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485949504581250,
"parent_rev": "68a8cb532edc3c8b53aa6eb717f2b44a7feb3147", "commit_rev":
"42011d29975898c3648241749cf1e96eac074b85"}
Message was sent while issue was closed.
Description was changed from ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org NOTRY=true ========== to ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2668953002 Cr-Commit-Position: refs/heads/master@{#42849} Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac0... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac0...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2664033005/ by bmeurer@chromium.org. The reason for reverting is: AAAAAHHHHHHH.
Message was sent while issue was closed.
Description was changed from ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2668953002 Cr-Commit-Position: refs/heads/master@{#42849} Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac0... ========== to ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2668953002 Cr-Commit-Position: refs/heads/master@{#42849} Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac0... ==========
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org Link to the patchset: https://codereview.chromium.org/2668953002/#ps40001 (title: "Cementation!")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485950710256150,
"parent_rev": "2f78186ee9f77e268d342b960c565965d8dc4300", "commit_rev":
"58611d0115ff4031e26aefaf7f571f4b3a26cf07"}
Message was sent while issue was closed.
Description was changed from ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2668953002 Cr-Commit-Position: refs/heads/master@{#42849} Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac0... ========== to ========== [tools] Fix RegExp for ticksprocessor. Properly attribute all builtins, bytecode handlers and other stubs to the calling function unless --separate-ic is passed. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2668953002 Cr-Original-Commit-Position: refs/heads/master@{#42849} Committed: https://chromium.googlesource.com/v8/v8/+/42011d29975898c3648241749cf1e96eac0... Review-Url: https://codereview.chromium.org/2668953002 Cr-Commit-Position: refs/heads/master@{#42852} Committed: https://chromium.googlesource.com/v8/v8/+/58611d0115ff4031e26aefaf7f571f4b3a2... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/58611d0115ff4031e26aefaf7f571f4b3a2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
