Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2664003002: Serialize calling of characteristic.writeValue in LayoutTests. (Closed)

Created:
3 years, 10 months ago by dougt
Modified:
3 years, 10 months ago
Reviewers:
ortuno
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Serialize calling of characteristic.writeValue in LayoutTests. characteristic.writeValue can not be called multiple times. If the UA is currently using the Bluetooth system (for example, if we are doing a writeValue) we may reject promise with a NetworkError. These "GATT operation in progress" errors may be addressed in the future (like having the UA magically serialize). See https://github.com/WebBluetoothCG/web-bluetooth/issues/188 for the spec issue. Here we are fixing the tests to ensure that we are serializing. Futher work is required to test for GATT operation in progress errors. BUG=None R=ortuno Review-Url: https://codereview.chromium.org/2664003002 Cr-Commit-Position: refs/heads/master@{#447139} Committed: https://chromium.googlesource.com/chromium/src/+/490c280a382a28d12640ead9e6d56671b59f7ef6

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dougt
ortuno, ptal
3 years, 10 months ago (2017-01-30 23:22:15 UTC) #3
ortuno
lgtm https://codereview.chromium.org/2664003002/diff/1/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html File third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html (right): https://codereview.chromium.org/2664003002/diff/1/third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html#newcode20 third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html:20: .then(() => characteristic.writeValue(new DataView(new ArrayBuffer(length)))) nit: you are ...
3 years, 10 months ago (2017-01-30 23:28:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2664003002/20001
3 years, 10 months ago (2017-01-31 00:11:28 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:49:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/490c280a382a28d12640ead9e6d5...

Powered by Google App Engine
This is Rietveld 408576698