third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html - Issue 2664003002: Serialize calling of characteristic.writeValue in LayoutTests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/writeValue/write-succeeds.html

Issue 2664003002: Serialize calling of characteristic.writeValue in LayoutTests. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/testharness.js"></script>	2 <script src="../../../resources/testharness.js"></script>

3 <script src="../../../resources/testharnessreport.js"></script>	3 <script src="../../../resources/testharnessreport.js"></script>

4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

	8 let length = 1;

	9 let characteristic;

8 return setBluetoothFakeAdapter('HeartRateAdapter')	10 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	11 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}],	12 filters: [{services: ['heart_rate']}],

11 optionalServices: ['generic_access']}))	13 optionalServices: ['generic_access']}))

12 .then(device => device.gatt.connect())	14 .then(device => device.gatt.connect())

13 .then(gattServer => gattServer.getPrimaryService('generic_access'))	15 .then(gattServer => gattServer.getPrimaryService('generic_access'))

14 .then(service => service.getCharacteristic('gap.device_name'))	16 .then(service => service.getCharacteristic('gap.device_name'))

15 .then(characteristic => Promise.all([	17 .then(c => characteristic = c)

16 characteristic.writeValue(new Uint8Array(1 /* length */)),	18 .then(() => characteristic.writeValue(new Uint8Array(length)))

17 characteristic.writeValue(new ArrayBuffer(1 /* length */)),	19 .then(() => characteristic.writeValue(new ArrayBuffer(length)))

18 characteristic.writeValue(new DataView(new ArrayBuffer(1 /* length */)))]) );	20 .then(() => characteristic.writeValue(new DataView(new ArrayBuffer(length))) )
	ortuno 2017/01/30 23:28:52 nit: you are missing a semicolon. nit: you are missing a semicolon.
19 }, 'A regular write request to a writable characteristic should succeed.');	21 }, 'A regular write request to a writable characteristic should succeed.');

20 </script>	22 </script>

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »