third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py - Issue 2663623003: Simplify the initialization of Git objects in Host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

Issue 2663623003: Simplify the initialization of Git objects in Host. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/style/main.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_server.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

index 11d3982c37e6f416413a95a6f091c689f5456702..70db2d4502a414fc0c3f448f6ef1c80d3ef7867f 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

@@ -50,7 +50,7 @@ class CommitAnnouncer(SingleServerIRCBot):

def __init__(self, tool, announce_path, irc_password):

SingleServerIRCBot.__init__(self, [(SERVER, PORT, irc_password)], NICKNAME, NICKNAME)

self.announce_path = announce_path

- self.git = Git(cwd=tool.scm().checkout_root, filesystem=tool.filesystem, executive=tool.executive)

+ self.git = tool.scm(tool.scm().checkout_root)

jeffcarp 2017/01/31 22:24:56 Was wondering why this was named tool, not host, a

qyearsley 2017/02/01 00:58:47 That's right, it is weird :-/ It would probably ma

self.commands = {

'help': self.help,

'ping': self.ping,