third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py - Issue 2663623003: Simplify the initialization of Git objects in Host.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

Issue 2663623003: Simplify the initialization of Git objects in Host. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/git.py ('K') | « third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py ('k') | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py » ('j') | third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

index 7c3a438262831b162571d7994145aedbb3763ca5..d44c592dc36ceea291ce725bb8317a52ee498c73 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py

@@ -341,7 +341,7 @@ def summarize_results(port_obj, expectations, initial_results,

results['chromium_revision'] = ''

if port_obj.get_option('builder_name'):

path = port_obj.repository_path()

- scm = port_obj.host.scm_for_path(path)

+ scm = port_obj.host.scm(path=path)

jeffcarp 2017/01/31 22:24:56 Some invocations use path= and some don't, would b

qyearsley 2017/02/01 00:58:47 Done

if scm:

results['chromium_revision'] = str(scm.commit_position(path))

else: