Simplify the initialization of Git objects in Host.

third_party/WebKit/Tools/Scripts/webkitpy/tool/bot/commit_announcer.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #    * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #    * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 32 matching lines @@
 UPDATE_WAIT_SECONDS = 10
 RETRY_ATTEMPTS = 8
 
 
 class CommitAnnouncer(SingleServerIRCBot):
     _commit_detail_format = "%H\n%ae\n%s\n%b"  # commit-sha1, author email, subject, body
 
     def __init__(self, tool, announce_path, irc_password):
         SingleServerIRCBot.__init__(self, [(SERVER, PORT, irc_password)], NICKNAME, NICKNAME)
         self.announce_path = announce_path
-        self.git = Git(cwd=tool.scm().checkout_root, filesystem=tool.filesystem, executive=tool.executive)
+        self.git = tool.scm(tool.scm().checkout_root)

[jeffcarp, 2017/01/31 22:24:56]

Was wondering why this was named tool, not host, and discovered that WebKitPatch
inherits from host, which seems like a weird pattern (no action needed, just
weird)
https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitp...

[qyearsley, 2017/02/01 00:58:47]

That's right, it is weird :-/ It would probably make more sense if WebKitPatch
had a Host member rather than being a subclass of Host.

There are probably other refactorings that we should do first, but I added a
FIXME note anyway for now. Does that seem OK?

         self.commands = {
             'help': self.help,
             'ping': self.ping,
             'quit': self.stop,
         }
         self.last_commit = None
 
     def start(self):
         if not self._update():
             return
@@ skipping 136 matching lines @@
     def __init__(self, tool, announce_path, irc_password):
         threading.Thread.__init__(self)
         self.bot = CommitAnnouncer(tool, announce_path, irc_password)
 
     def run(self):
         self.bot.start()
 
     def stop(self):
         self.bot.stop()
         self.join()